Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): relax longitudinal_velocity_delta_time #4039

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Jun 22, 2023

Description

Changed parameter to be less likely to cancel based on the speed of vehicles in adjacent lanes.
Related PR: autowarefoundation/autoware_launch#410

Tests performed

With real vehicle

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@shmpwk shmpwk enabled auto-merge (squash) June 22, 2023 06:03
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (57c958f) 14.41% compared to head (2b5a331) 14.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4039      +/-   ##
==========================================
- Coverage   14.41%   14.33%   -0.08%     
==========================================
  Files        1456     1456              
  Lines      102660   105429    +2769     
  Branches    29728    31779    +2051     
==========================================
+ Hits        14795    15110     +315     
- Misses      71705    73818    +2113     
- Partials    16160    16501     +341     
Flag Coverage Δ *Carryforward flag
differential 12.70% <ø> (?)
total 14.41% <ø> (+<0.01%) ⬆️ Carriedforward from 57c958f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shmpwk shmpwk merged commit f6f3bab into main Jun 22, 2023
@shmpwk shmpwk deleted the feat/relax_lc branch June 22, 2023 07:03
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Jun 22, 2023
shmpwk added a commit that referenced this pull request Jun 23, 2023
shmpwk added a commit that referenced this pull request Jun 23, 2023
…ta_time" (#4064)

Revert "feat(behavior_path_planner): relax longitudinal_velocity_delta_time (#4039)"

This reverts commit f6f3bab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants