Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(behavior_path_planner): relax longitudinal_velocity_delta_time" #4064

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Jun 23, 2023

Reverts #4039 because of scenario test fails

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 3.65% and project coverage change: +0.29 🎉

Comparison is base (3b162aa) 14.31% compared to head (4fc42ae) 14.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4064      +/-   ##
==========================================
+ Coverage   14.31%   14.60%   +0.29%     
==========================================
  Files        1557     1570      +13     
  Lines      106900   107759     +859     
  Branches    30777    31306     +529     
==========================================
+ Hits        15302    15740     +438     
- Misses      75028    75050      +22     
- Partials    16570    16969     +399     
Flag Coverage Δ *Carryforward flag
differential 13.57% <3.65%> (?)
total 14.32% <ø> (+<0.01%) ⬆️ Carriedforward from 3b162aa

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.hpp ∅ <ø> (∅)
...e/updater/occupancy_grid_map_updater_interface.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 18.86% <ø> (+18.86%) ⬆️
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 17.63% <0.00%> (-0.70%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 13.15% <0.00%> (+9.01%) ⬆️
... and 6 more

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shmpwk shmpwk merged commit 4bc5ccc into main Jun 23, 2023
@shmpwk shmpwk deleted the revert-4039-feat/relax_lc branch June 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants