Add jupyter notebooks to ecosystem checks

[zanieb]

Implements #8873 via #9286

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

[zanieb]

Are these real issues with our formatter? cc @dhruvmanila

[konstin]

I checked some of the notebooks and they did contain syntax errors.

The error messages should have a cell number though.

[zanieb]

Yes I can confirm the huggingface notebooks are all over the place and have invalid syntax. We should improve the formatter error messages in those cases, but that's a separate concern (#9311). I've fixed the errors in zanieb/huggingface-notebooks@68cd6fa but contributing upstream seems like a pain since the notebooks are synced from other repositories and the content is full of problems.

I opened a fix for the openai-cookbook error at openai/openai-cookbook#964

[zanieb]

Hm very interesting, do we mutate cell ids?

  "cells": [
   {
    "cell_type": "markdown",
-   "id": "3f738710-b5ef-46c4-b874-f13221ee9f76",
+   "id": "754e1af3-4775-4211-a476-d0f698c81cd4",
    "metadata": {
     "colab_type": "text",
     "id": "view-in-github"

[zanieb]

We create IDs if they do not exist at

ruff/crates/ruff_notebook/src/notebook.rs

Lines 155 to 158 in c01bb0d

	if id.is_none() {
	// https://github.com/jupyter/enhancement-proposals/blob/master/62-cell-id/cell-id.md#questions
	*id = Some(Uuid::new_v4().to_string());
	}

Presumably this just differs on each run of the Ruff formatter. Hm. I guess we could seed for determinism?

[zanieb]

Rebasing onto #9359

[zanieb]

See fix for ibis #9392

[charliermarsh]

Why these?

[zanieb]

@dhruvmanila chose them — they're rules that have different behavior for notebooks or something? Idk if we really need to select a subset though?

[charliermarsh]

Yeah I'd probably just expand them, but nbd either way.

[zanieb]

Like extend select? I'll just wait for Dhruv to be available — not crtical.

[dhruvmanila]

they're rules that have different behavior for notebooks or something?

Yeah, I chose them for this exact reason but it's reasonable to just expand them and use extend-select if possible.