Fix syntax error in W&B weave notebook #964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a very minor change which updates the W&B Weave example notebook to use valid syntax.
Motivation
For context, there's a variable which they want the user to assign a value to e.g.
FOO = # set a value
but this is invalid syntax and could be confusing to some users. I've edited it to beFOO = "" # set a value
. I discovered this while attempting to include this project in Ruff's ecosystem checks at astral-sh/ruff#9293.There is a minor chance that this would increase confusion as the notebook will no longer fail with a syntax error if the user does not set a value. It'd be trivial to add additional code that checks the value of the variable and raises an informative error if that's a concern. I am happy to do so, but wanted to start with the smaller changer.