-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Consider linting or formatting notebooks #1037
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
👋 hi bot. I believe this is still relevant. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This issue was closed because it has been stalled for 10 days with no activity. |
@shyamal-anadkat would you be willing to consider this or similar? We'd really like to continue using this repository to help verify that changes to our behavior with notebooks is correct, but there are constantly notebooks with syntax errors:
|
I've opened a couple pull requests now resolving syntax errors in notebooks (#1036, #964)
It seems like you should have at least a simple check in CI that notebooks are valid. If you add formatting to CI, you'll get automatic checks for syntax errors and consistent notebook formatting. Alternatively, you use a linter without enabling anything more than syntax errors.
The text was updated successfully, but these errors were encountered: