Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Consider linting or formatting notebooks #1037

Closed
zanieb opened this issue Feb 2, 2024 · 5 comments
Closed

[FEATURE] Consider linting or formatting notebooks #1037

zanieb opened this issue Feb 2, 2024 · 5 comments
Labels

Comments

@zanieb
Copy link
Contributor

zanieb commented Feb 2, 2024

I've opened a couple pull requests now resolving syntax errors in notebooks (#1036, #964)

It seems like you should have at least a simple check in CI that notebooks are valid. If you add formatting to CI, you'll get automatic checks for syntax errors and consistent notebook formatting. Alternatively, you use a linter without enabling anything more than syntax errors.

Copy link

github-actions bot commented Apr 3, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 3, 2024
@zanieb
Copy link
Contributor Author

zanieb commented Apr 3, 2024

👋 hi bot. I believe this is still relevant.

@github-actions github-actions bot removed the Stale label Apr 4, 2024
Copy link

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 3, 2024
Copy link

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
@zanieb
Copy link
Contributor Author

zanieb commented Aug 7, 2024

@shyamal-anadkat would you be willing to consider this or similar? We'd really like to continue using this repository to help verify that changes to our behavior with notebooks is correct, but there are constantly notebooks with syntax errors:

error: Failed to parse examples/Chat_finetuning_data_prep.ipynb:6:18:25: Unparenthesized generator expression cannot be used here
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_confluence.ipynb:15:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_gmail.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_jira.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_notion.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_doc.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_text.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sql_database.ipynb:2:2:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_middleware_azure_function.ipynb:37:1:13: Simple statements must be separated by newlines or semicolons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant