Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter notebooks to ecosystem checks #9293

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Add jupyter notebooks to ecosystem checks #9293

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34774cc
Add jupyter notebooks to ecosystem checks
zanieb Dec 27, 2023
fa7b9cb
Use fixed fork of `huggingface/notebooks`
zanieb Dec 29, 2023
56cf7f9
Rename fork
zanieb Dec 29, 2023
37a7152
Use branch instead of commit
zanieb Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions python/ruff-ecosystem/ruff_ecosystem/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
Repository,
)

JUPYTER_NOTEBOOK_SELECT = "A,E703,F704,B015,B018,D100"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvmanila chose them — they're rules that have different behavior for notebooks or something? Idk if we really need to select a subset though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'd probably just expand them, but nbd either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like extend select? I'll just wait for Dhruv to be available — not crtical.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're rules that have different behavior for notebooks or something?

Yeah, I chose them for this exact reason but it's reasonable to just expand them and use extend-select if possible.


# TODO(zanieb): Consider exporting this as JSON and loading from there instead
DEFAULT_TARGETS = [
Project(repo=Repository(owner="DisnakeDev", name="disnake", ref="master")),
Expand Down Expand Up @@ -93,4 +95,20 @@
repo=Repository(owner="zulip", name="zulip", ref="main"),
check_options=CheckOptions(select="ALL"),
),
# Jupyter Notebooks
Project(
# fork of `huggingface` without syntax errors in notebooks
repo=Repository(
owner="zanieb",
name="huggingface-notebooks",
ref="zb/fix-syntax",
),
check_options=CheckOptions(select=JUPYTER_NOTEBOOK_SELECT),
config_overrides={"include": ["*.ipynb"]},
),
Project(
repo=Repository(owner="openai", name="openai-cookbook", ref="main"),
check_options=CheckOptions(select=JUPYTER_NOTEBOOK_SELECT),
config_overrides={"include": ["*.ipynb"]},
),
]
Loading