Exclude failing sphinx file in ecosytem checks #9294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/ecosystem-sphinx
branch
from
ba51e3b to
f213b28
Compare
|
MichaReiser
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
IMO: It's the right response to continue getting value from the ecosystem.
Whether it's worth reconsidering our standpoint on supporting Python's encoding headers is a separate question (that, interestingly, hasn't come up as a user-reported issue).
Code wise: Neat how flexible the ecosystem checks are :)
zanieb
added a commit
that referenced
this pull request
Dec 28, 2023
Adds the ability to override `ruff.toml` or `pyproject.toml` settings per-project during ecosystem checks. Exploring this as a fix for the `setuptools` project error. Also useful for including Jupyter Notebooks in the ecosystem checks, see #9293 Note the remaining `sphinx` project error is resolved in #9294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing due to
Unclear to me if ignoring is the correct response.