-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to test python -m ruff
on release
#4397
Merged
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, great idea. |
Hopefully CI actually fails here? :) |
@charliermarsh I only updated the |
Oh right right. Thanks. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
thanks! |
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
May 12, 2023
Warns when the user explicitly set `python-source` but that folder doesn't contain a python module. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is `ruff_cli` and i didn't realize this takes precedence as module name over the package name. The extra boolean isn't pretty but i wanted to avoid refactoring the entire method just for that.
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
May 12, 2023
…name` over Cargo.toml `package.name`. I propose to change the precedence for determining the module name to consider before pyproject.toml `project.name` over Cargo.toml `package.name`. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is `ruff_cli` and the project name is `ruff`. I'm not sure if there are any cases a user would like the crate name over the package name.
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
May 12, 2023
Warns when the user explicitly set `python-source` but that folder doesn't contain a python module. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is `ruff_cli` and i didn't realize this takes precedence as module name over the package name. The extra boolean isn't pretty but i wanted to avoid refactoring the entire method just for that.
This was referenced May 12, 2023
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
May 13, 2023
Warns when the user explicitly set `python-source` but that folder doesn't contain a python module. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is `ruff_cli` and i didn't realize this takes precedence as module name over the package name. The extra boolean isn't pretty but i wanted to avoid refactoring the entire method just for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent future regressions like #4394