-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to test Python wheel on Linux #4398
Conversation
- name: "Build wheels" | ||
uses: PyO3/maturin-action@v1 | ||
with: | ||
manylinux: auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to use container: off
to run this directly on the host instead of a container (for speed?) this is closer to the release build though so 🤷♀️
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
I'm a little confused that this built 0.0.267 and didn't fail — seems like it built from the fixes in |
Sorry, what do you mean exactly? I expected this to pass as long as it includes #4399 in the upstream. |
Oh yeah, I agree, this should've failed right? |
Yeah this branches off of tldr; this would have failed before but you merged a fix into |
Follow-up to #4397 to prevent regressions like #4394 per pull request.