Latest ruff 0.0.266 fails to import

[jaraco]

I was working on jaraco/jaraco.packaging#11 when suddenly the tests started failing with ModuleNotFoundError. I traced it to the recent 0.0.266 release:

 ~ $ pip-run -v ruff -- -c "import ruff"
Collecting ruff
  Using cached ruff-0.0.266-py3-none-macosx_10_9_x86_64.macosx_11_0_arm64.macosx_10_9_universal2.whl (10.1 MB)
Installing collected packages: ruff
Successfully installed ruff-0.0.266
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'ruff'

[zanieb]

Confirmed this reproduces on 0.0.266 with python -c "import ruff" but not on 0.0.265. @jaraco might be worth updating your title to note that just the Python import is broken. ruff runs fine.

[jaraco]

I can see the binary there, but no library:

 ~ $ pip-run ruff
Python 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.path
['', '/var/folders/sx/n5gkrgfx6zd91ymxr2sr9wvw00n8zm/T/pip-run-h27rhwxt', '/opt/homebrew/Cellar/[email protected]/3.11.3/Frameworks/Python.framework/Versions/3.11/lib/python311.zip', '/opt/homebrew/Cellar/[email protected]/3.11.3/Frameworks/Python.framework/Versions/3.11/lib/python3.11', '/opt/homebrew/Cellar/[email protected]/3.11.3/Frameworks/Python.framework/Versions/3.11/lib/python3.11/lib-dynload', '/opt/homebrew/Cellar/[email protected]/3.11.3/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages']
>>> import pathlib
>>> libs = pathlib.Path(sys.path[1])
>>> list(libs.iterdir())
[PosixPath('/var/folders/sx/n5gkrgfx6zd91ymxr2sr9wvw00n8zm/T/pip-run-h27rhwxt/bin'), PosixPath('/var/folders/sx/n5gkrgfx6zd91ymxr2sr9wvw00n8zm/T/pip-run-h27rhwxt/__pycache__'), PosixPath('/var/folders/sx/n5gkrgfx6zd91ymxr2sr9wvw00n8zm/T/pip-run-h27rhwxt/sitecustomize.py'), PosixPath('/var/folders/sx/n5gkrgfx6zd91ymxr2sr9wvw00n8zm/T/pip-run-h27rhwxt/ruff-0.0.266.dist-info')]
>>> list(libs.joinpath('bin').iterdir())
[PosixPath('/var/folders/sx/n5gkrgfx6zd91ymxr2sr9wvw00n8zm/T/pip-run-h27rhwxt/bin/ruff')]

[jaraco]

Can I expect a rapid mitigation (fix or yank) or should I invest in working around the issue?

[charliermarsh]

I'm surprised that import ruff worked before, but I'm guessing this is related to our Maturin upgrade? Gimme a few mins to look into it. Worst-case I will revert the Maturin change and cut a new release.

[zanieb]

@charliermarsh looks like the site-packages/ruff directory is missing.

@jaraco why do you use import ruff?

[edgarrmondragon]

fwiw this is causing problems for nbqa-ruff too

[charliermarsh]

Alright, I'll go ahead and revert while we figure this out.

python -m ruff file.py is also failing.

[charliermarsh]

Yanked for now.

[charliermarsh]

I'll have a new release out within the next hour.

[jaraco]

Yanked for now.

Super helpful and unblocked my work. Thanks for the super-rapid response.

[charliermarsh]

Thanks for raising the issue so quickly, and apologies for the churn.

I did do some manual testing of the wheels prior to cutting the release, since we upgraded Maturin, but I didn't test the use of Ruff-as-module, and it turns out we didn't have any automated testing for that either, which @madkinsz has already improved :)

[charliermarsh]

Fixed in v0.0.267.

[jaraco]

@jaraco why do you use import ruff?

I use pytest-ruff, which imports ruff.