Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When determining the python module name, use pyproject.toml project.name over Cargo.toml package.name. #1608

Merged
merged 1 commit into from
May 13, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented May 12, 2023

I propose to change the precedence for determining the module name to consider before pyproject.toml project.name over Cargo.toml package.name. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is ruff_cli and the project name is ruff.

I'm not sure if there are any cases a user would like the crate name over the package name.

…name` over Cargo.toml `package.name`.

I propose to change the precedence for determining the module name to consider before pyproject.toml `project.name` over Cargo.toml `package.name`. This came up in ruff (astral-sh/ruff#4397, astral-sh/ruff#4399), where the crate name is `ruff_cli` and the project name is `ruff`.

I'm not sure if there are any cases a user would like the crate name over the package name.
@netlify
Copy link

netlify bot commented May 12, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 02f5764
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/645ece8637caae00072b3374
😎 Deploy Preview https://deploy-preview-1608--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense added this pull request to the merge queue May 13, 2023
Merged via the queue into main with commit 243b8ec May 13, 2023
@messense messense deleted the use_project_name_for_module_name branch May 13, 2023 01:31
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 21, 2023

Verified

This commit was signed with the committer’s verified signature.
bmwiedemann Bernhard M. Wiedemann
https://build.opensuse.org/request/show/1088131
by user mia + dimstar_suse
- Update to v0.15.3:
  * Fix cross-compile to Apple universal2 in the other platform
    gh#PyO3/maturin#1613
  * Remove serde(flatten) to improve error messages
    gh#PyO3/maturin#1616
  * Allow syn 2.0
    gh#PyO3/maturin#1617
  * describe the need for module-name
    gh#PyO3/maturin#1604
  * Add PEP 517 config_settings support
    gh#PyO3/maturin#1619
  * Keep file mode on Unix
    gh#PyO3/maturin#1622
- Changes in v0.15.2:
  * Remove bors
    gh#PyO3/maturin#1602
  * When determining the python module name, use pyproject.toml
    project.name over Cargo.toml package.name.
    gh#PyO3/maturin#1608
  * Warn on missing python-source contents
    gh#PyO3/maturin#1607
  * Fix rewriting dev-dependencies in sdist
    gh#PyO3/maturin#1610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants