Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on maturin 0.15.2 and above #241

Closed
evilmav opened this issue Jun 13, 2023 · 0 comments · Fixed by #244
Closed

Fix build on maturin 0.15.2 and above #241

evilmav opened this issue Jun 13, 2023 · 0 comments · Fixed by #244
Assignees
Labels
bug Something isn't working

Comments

@evilmav
Copy link

evilmav commented Jun 13, 2023

Describe the bug

Maturin build fails starting with 0.15.x with

Warning: Couldn't find the symbol `PyInit_pyqir` in the native library. Python will fail to import this module. If you're using pyo3, check that `#[pymodule]` uses `pyqir` as module name

and failure to import the pyqir._native module at runtime. The behavior might be related to the change in 0.15.2: PyO3/maturin#1608

To Reproduce

Steps to reproduce the behavior:

  1. Install a recent maturin version
  2. cd into pyqir/
  3. Run maturin build --release -F llvm14-0
  4. See warning

Expected behavior

The warning should not happen. The resulting module should be importable.

System information

  • Tried on arch with maturin 1.0.1 installed as well as during NixOS packaging, where the package build with 23.05 stable realese shipping maturin 14.17 but not the unstable branch.
@evilmav evilmav added the bug Something isn't working label Jun 13, 2023
@sezna sezna self-assigned this Jul 26, 2023
@sezna sezna closed this as completed in #244 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants