Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #481] Use YAML file to store configuration #3988

Open
wants to merge 4,082 commits into
base: master
Choose a base branch
from

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented May 21, 2023

Fixes #481.

Motivation

See "Enhancement Request" in issue.

Modifications

The default config file format keeps eventmesh.properties. When user set only config file in yaml / yml format, EventMesh will find it and load it.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

kyooosukedn and others added 30 commits April 3, 2023 23:20
…gfatguy.fb-contrib-fb-contrib-7.6.0

Bump com.mebigfatguy.fb-contrib:fb-contrib from 7.4.7 to 7.6.0
Removed the parameter 'defaultValue' at line 256. Replaced 'defaultvalue' with "" at line 258 . I have also removed the third parameter at lines 196 and 197.
Swapped actual and expected values in lines 47,48,63,64,75,76.
I have swapped the actual and expected values in the lines 137-155.
Replaced "replaceAll()" with "replace()"
Replaced "replaceAll()" to "replace()"
Replaced "replaceAll()" with "replace()"
Changed "size()>0" to "isEmpty()"
[ISSUE apache#3395]Use isEmpty() to check whether the collection is empty or not.[ClientSessionGroupMapping]
[ISSUE apache#3464]Replace this call to "replaceAll()" by a call to the "replace()" method.[EventMeshVersion]
[ISSUE apache#3483]Replace this call to "replaceAll()" by a call to the "replace()" method.[PushConsumerImpl]
[ISSUE apache#3518]Swap these 2 arguments so they are in the correct order: expected value, actual value.[HttpTinyClientTest]
[ISSUES apache#3482]Replace this call to "replaceAll()" by a call to the "replace()" method.[ProducerImpl]
[ISSUE apache#3517]Swap these 2 arguments so they are in the correct order: expected value, actual value.[PubClientImpl]
[ISSUE apache#3165]Actual value of parameter 'defaultValue' is always"
Swapped actual and expected values in the lines 37-39 and 45.
Swapped actual and expected values.
Swapped actual and expected values in lines 52,62,68
Returns empty map/list instead of null
Included "import java.util.Objects;" at line 28. Included "Object.requireNonNull()" at line 80
Swapped actual and expected values at lines 46-48.
a. Replaced 'config == null ? false : config.monitor()' with 'config != null && config.monitor()' at line 84
b. Imported 'java.util.Objects'
Also, 'Objects.requireNonNull(resourceUrl)' at line 130
Included "final" in the lines 41, 42, 44, 46. Removed curly braces at line 61.
mxsm and others added 12 commits May 30, 2023 15:12
…pache#3953)

* [ISSUE apache#3952]Optimize EventMeshServer#EventMeshServer method

* add if no protocols are provided, initialize BOOTSTRAP_LIST with default protocols

* set default protocol is tcp

* add default branch
[ISSUE apache#4029 ] Comparison using reference equality instead of value equality.[Heartbeat]
…pache#3987)

* Issue apache#3827

Changed Access modifier of `items[]`
Added getters for the same
Changed Breaking tests

* Renamed reentrant lock inside method scopes
…nterException'. (apache#3971)

* fixes [Enhancement] apache#3963

* Fix Updated

* Update QueryWebHookConfigByIdHandler.java

---------

Co-authored-by: mike_xwm <[email protected]>
… global variables in ZipkinTraceService, PinpointTraceService (apache#3945)

* Add an base class for EventMeshTraceService's implementations.;

* Fix CI error.

* Fix CI error.

* Fix checkstyle error.

* Fix checkstyle error.

* Fix test case bug.
apache#3925)

* Add unit test for UrlMappingPattern, RequestMapping

* Fix test case bug.
…th lambda (apache#3923)

* [ISSUE apache#3909] Replaced anonymous new ChannelFutureListener() with lambda

* Fixed checkstyle for source-connector-rocketmq

* Fixed checkstyle for eventmesh-storage-rocketmq
@Pil0tXia
Copy link
Member

I think we should only use one configuration file, either eventmesh.yml or eventmesh.properties. Having both concurrently would pose difficulties in maintenance.

Considering that connectors all use YAML configuration files, the presence of eventmesh.properties feels inconsistent, since it is one of the few properties files in EventMesh. Therefore, my preference would be to standardize the use of YAML files.

In our project, we currently have both .yml and .yaml files, and both file extensions are valid. However, it would be necessary to choose one for consistency. Although .yaml is a more standard and compliant file extension compared to .yml, the majority of our project uses .yml. Hence, I recommend standardizing on the .yml extension (except for .asf.yaml).

@pandaapo
Copy link
Member Author

I think we should only use one configuration file, either eventmesh.yml or eventmesh.properties. Having both concurrently would pose difficulties in maintenance.

Considering that connectors all use YAML configuration files, the presence of eventmesh.properties feels inconsistent, since it is one of the few properties files in EventMesh. Therefore, my preference would be to standardize the use of YAML files.

In our project, we currently have both .yml and .yaml files, and both file extensions are valid. However, it would be necessary to choose one for consistency. Although .yaml is a more standard and compliant file extension compared to .yml, the majority of our project uses .yml. Hence, I recommend standardizing on the .yml extension (except for .asf.yaml).

Thanks for your review. But sorry, many of your points I couldn't agree with, and they were even a bit strange to me. No offense, I'm willing to wait for more members of the community to express their views on these points of yours. If there are no objections, I will revise.

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 30.66667% with 52 lines in your changes missing coverage. Please review.

Project coverage is 14.22%. Comparing base (fb144bb) to head (2bb30ef).
Report is 514 commits behind head on master.

Current head 2bb30ef differs from pull request most recent head 83fb56e

Please upload reports for the commit 83fb56e to get more accurate results.

Files Patch % Lines
...org/apache/eventmesh/common/file/YamlFileLoad.java 4.54% 21 Missing ⚠️
...a/org/apache/eventmesh/common/utils/FileUtils.java 0.00% 21 Missing ⚠️
.../apache/eventmesh/common/config/ConfigService.java 16.66% 5 Missing ⚠️
...ava/org/apache/eventmesh/common/file/FileLoad.java 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3988      +/-   ##
============================================
- Coverage     14.22%   14.22%   -0.01%     
  Complexity     1328     1328              
============================================
  Files           580      583       +3     
  Lines         28856    29013     +157     
  Branches       2792     2810      +18     
============================================
+ Hits           4105     4127      +22     
- Misses        24361    24494     +133     
- Partials        390      392       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the Stale label Apr 21, 2024
@Pil0tXia Pil0tXia changed the title [ISSUE #481]Use YAML file to store configuration [ISSUE #481] Use YAML file to store configuration Apr 24, 2024
@Pil0tXia
Copy link
Member

Any progress we can make here?

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 23, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use YAML file to store configuration