-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #481] Use YAML file to store configuration #3988
base: master
Are you sure you want to change the base?
Conversation
Fix patch 3401
…gfatguy.fb-contrib-fb-contrib-7.6.0 Bump com.mebigfatguy.fb-contrib:fb-contrib from 7.4.7 to 7.6.0
Removed the parameter 'defaultValue' at line 256. Replaced 'defaultvalue' with "" at line 258 . I have also removed the third parameter at lines 196 and 197.
Swapped actual and expected values in lines 47,48,63,64,75,76.
I have swapped the actual and expected values in the lines 137-155.
Replaced "replaceAll()" with "replace()"
Replaced "replaceAll()" to "replace()"
Replaced "replaceAll()" with "replace()"
Changed "size()>0" to "isEmpty()"
[ISSUE apache#3395]Use isEmpty() to check whether the collection is empty or not.[ClientSessionGroupMapping]
[ISSUE apache#3464]Replace this call to "replaceAll()" by a call to the "replace()" method.[EventMeshVersion]
[ISSUE apache#3483]Replace this call to "replaceAll()" by a call to the "replace()" method.[PushConsumerImpl]
[ISSUE apache#3518]Swap these 2 arguments so they are in the correct order: expected value, actual value.[HttpTinyClientTest]
[ISSUES apache#3482]Replace this call to "replaceAll()" by a call to the "replace()" method.[ProducerImpl]
[ISSUE apache#3517]Swap these 2 arguments so they are in the correct order: expected value, actual value.[PubClientImpl]
[ISSUE apache#3165]Actual value of parameter 'defaultValue' is always"
Swapped actual and expected values in the lines 37-39 and 45.
Swapped actual and expected values.
Swapped actual and expected values in lines 52,62,68
Returns empty map/list instead of null
Included "import java.util.Objects;" at line 28. Included "Object.requireNonNull()" at line 80
Swapped actual and expected values at lines 46-48.
a. Replaced 'config == null ? false : config.monitor()' with 'config != null && config.monitor()' at line 84 b. Imported 'java.util.Objects' Also, 'Objects.requireNonNull(resourceUrl)' at line 130
Included "final" in the lines 41, 42, 44, 46. Removed curly braces at line 61.
…me or Charset object explicitly.
…pache#3953) * [ISSUE apache#3952]Optimize EventMeshServer#EventMeshServer method * add if no protocols are provided, initialize BOOTSTRAP_LIST with default protocols * set default protocol is tcp * add default branch
[ISSUE apache#4029 ] Comparison using reference equality instead of value equality.[Heartbeat]
Update README.md
…pache#3987) * Issue apache#3827 Changed Access modifier of `items[]` Added getters for the same Changed Breaking tests * Renamed reentrant lock inside method scopes
…nterException'. (apache#3971) * fixes [Enhancement] apache#3963 * Fix Updated * Update QueryWebHookConfigByIdHandler.java --------- Co-authored-by: mike_xwm <[email protected]>
… global variables in ZipkinTraceService, PinpointTraceService (apache#3945) * Add an base class for EventMeshTraceService's implementations.; * Fix CI error. * Fix CI error. * Fix checkstyle error. * Fix checkstyle error. * Fix test case bug.
apache#3925) * Add unit test for UrlMappingPattern, RequestMapping * Fix test case bug.
…th lambda (apache#3923) * [ISSUE apache#3909] Replaced anonymous new ChannelFutureListener() with lambda * Fixed checkstyle for source-connector-rocketmq * Fixed checkstyle for eventmesh-storage-rocketmq
I think we should only use one configuration file, either Considering that connectors all use YAML configuration files, the presence of In our project, we currently have both |
Thanks for your review. But sorry, many of your points I couldn't agree with, and they were even a bit strange to me. No offense, I'm willing to wait for more members of the community to express their views on these points of yours. If there are no objections, I will revise. |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3988 +/- ##
============================================
- Coverage 14.22% 14.22% -0.01%
Complexity 1328 1328
============================================
Files 580 583 +3
Lines 28856 29013 +157
Branches 2792 2810 +18
============================================
+ Hits 4105 4127 +22
- Misses 24361 24494 +133
- Partials 390 392 +2 ☔ View full report in Codecov by Sentry. |
Any progress we can make here? |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #481.
Motivation
See "Enhancement Request" in issue.
Modifications
The default config file format keeps
eventmesh.properties
. When user set only config file in yaml / yml format, EventMesh will find it and load it.Documentation