Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[HttpTinyClientTest] #3518

Closed
1 of 2 tasks
Alonexc opened this issue Mar 22, 2023 · 0 comments · Fixed by #3628
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Mar 22, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
Located at:
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/util/HttpTinyClientTest.java line 47,48,63,64,75,76
analysis and explanation:
The standard assertions library methods such as org.junit.Assert.assertEquals, and org.junit.Assert.assertSame expect the first argument to be the expected value and the second argument to be the actual value. For AssertJ, it’s the other way around, the argument of org.assertj.core.api.Assertions.assertThat is the actual value, and the subsequent calls contain the expected values. Swap them, and your test will still have the same outcome (succeed/fail when it should) but the error messages will be confusing.

Describe the solution you'd like

Swap actual and expected values.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Mar 22, 2023
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Mar 28, 2023
xwm1992 added a commit that referenced this issue Apr 6, 2023
[ISSUE #3518]Swap these 2 arguments so they are in the correct order: expected value, actual value.[HttpTinyClientTest]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
2 participants