Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4029 ] Comparison using reference equality instead of value equality.[Heartbeat] #4037

Merged
merged 2 commits into from
May 30, 2023
Merged

[ISSUE #4029 ] Comparison using reference equality instead of value equality.[Heartbeat] #4037

merged 2 commits into from
May 30, 2023

Conversation

nitheesh-daram
Copy link
Contributor

This PR Resolves #4029

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #4037 (745b205) into master (4db7667) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 745b205 differs from pull request most recent head 5b09589. Consider uploading reports for the commit 5b09589 to get more accurate results

@@            Coverage Diff            @@
##             master    #4037   +/-   ##
=========================================
  Coverage     14.25%   14.25%           
  Complexity     1320     1320           
=========================================
  Files           579      579           
  Lines         28943    28943           
  Branches       2794     2794           
=========================================
  Hits           4125     4125           
  Misses        24426    24426           
  Partials        392      392           
Impacted Files Coverage Δ
...entmesh/common/protocol/grpc/protos/Heartbeat.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wqliang wqliang merged commit a6a2793 into apache:master May 30, 2023
@nitheesh-daram nitheesh-daram deleted the ISSUE-4029 branch June 24, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Comparison using reference equality instead of value equality.[Heartbeat]
5 participants