Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize EventMeshServer#EventMeshServer method #3952

Closed
2 tasks done
mxsm opened this issue May 17, 2023 · 0 comments · Fixed by #3953
Closed
2 tasks done

[Enhancement] Optimize EventMeshServer#EventMeshServer method #3952

mxsm opened this issue May 17, 2023 · 0 comments · Fixed by #3953
Labels
enhancement New feature or request

Comments

@mxsm
Copy link
Member

mxsm commented May 17, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Optimize EventMeshServer#EventMeshServer method.

image

use a switch statement instead of multiple if statements to check for the server protocols

Describe the solution you'd like

use a switch statement instead of multiple if statements to check for the server protocols

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@mxsm mxsm added the enhancement New feature or request label May 17, 2023
mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue May 17, 2023
@mxsm
[ISSUE apache#3952]Optimize EventMeshServer#EventMeshServer method
2210315
@mxsm mxsm mentioned this issue May 17, 2023
Merged
mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue May 22, 2023
@mxsm
[ISSUE apache#3952]Optimize EventMeshServer#EventMeshServer method
33b04f1
mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue May 26, 2023
@mxsm
[ISSUE apache#3952]Optimize EventMeshServer#EventMeshServer method
5fd4e03
xwm1992 pushed a commit that referenced this issue May 30, 2023
@mxsm
[ISSUE #3952]Optimize EventMeshServer#EventMeshServer method (#3953)
3092643 
* [ISSUE #3952]Optimize EventMeshServer#EventMeshServer method

* add if no protocols are provided, initialize BOOTSTRAP_LIST with default protocols

* set default protocol is tcp

* add default branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #3952]Optimize EventMeshServer#EventMeshServer method mxsm/incubator-eventmesh
1 participant
@mxsm