Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extra annotations pgbouncer #30168

Merged
merged 9 commits into from
Apr 10, 2023
Merged

feat: add extra annotations pgbouncer #30168

merged 9 commits into from
Apr 10, 2023

Conversation

dim-ops
Copy link
Contributor

@dim-ops dim-ops commented Mar 17, 2023

Add extra annotations for pgbouncer deployment

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 17, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@josh-fell josh-fell mentioned this pull request Mar 18, 2023
Closed
@dim-ops dim-ops force-pushed the feat/add-extra-annotations-pgbouncer branch from 4f8f662 to 4847263 Compare March 18, 2023 06:44
@dim-ops dim-ops marked this pull request as ready for review March 18, 2023 06:45
@dim-ops
Copy link
Contributor Author

dim-ops commented Mar 20, 2023

Hello @josh-fell, I'm not sure to understand why Tests / Static checksfails, can you explain me ?

@dim-ops
Copy link
Contributor Author

dim-ops commented Mar 20, 2023

I think I finally figured out the error in the IC E501 Line too long means I have too many characters on one line, I formatted my code another way.

I have another solution otherwise @josh-fell

@dim-ops
Copy link
Contributor Author

dim-ops commented Mar 20, 2023

@herlambang I begin my PR before you, maybe you can push the content of tests/charts/test_annotations.py to share this PR ?

@dim-ops dim-ops force-pushed the feat/add-extra-annotations-pgbouncer branch 2 times, most recently from b65d9df to 311920c Compare March 22, 2023 21:03
@dim-ops dim-ops force-pushed the feat/add-extra-annotations-pgbouncer branch from 311920c to 2e67aee Compare April 2, 2023 18:40
@dim-ops
Copy link
Contributor Author

dim-ops commented Apr 4, 2023

@JoshFell is it possible to merge ?

@josh-fell
Copy link
Contributor

@JoshFell is it possible to merge ?

I wouldn't be the best person to review this PR as I have never worked with the charts. (I just noticed there seemed to be very similar PRs open between yours and another.) I'd feel more comfortable if the code owners weighed in.

I did kick off CI for you which was waiting for approval to run.

jedcunningham
jedcunningham requested changes Apr 8, 2023
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
tests/charts/test_pgbouncer.py Outdated Show resolved Hide resolved
chart/templates/pgbouncer/pgbouncer-deployment.yaml Outdated Show resolved Hide resolved
@dim-ops dim-ops force-pushed the feat/add-extra-annotations-pgbouncer branch from bf25781 to b685ac0 Compare April 9, 2023 16:59
@dim-ops dim-ops requested a review from jedcunningham April 9, 2023 18:51
@jedcunningham jedcunningham merged commit 78ab400 into apache:main Apr 10, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 10, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

Thanks @dim-ops! Congrats on your first commit 🎉

@jedcunningham jedcunningham mentioned this pull request Apr 11, 2023
Closed
30 tasks
This was referenced Jun 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedcunningham jedcunningham jedcunningham approved these changes

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

Assignees
No one assigned
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Milestone
Airflow Helm Chart 1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dim-ops @josh-fell @jedcunningham