-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod annotation on PgBouncer #30172
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just couple minor things to clean up.
de1a047
to
7c2f906
Compare
@jedcunningham How does this compare/differ from #30168? |
7c2f906
to
ba43f47
Compare
ba43f47
to
675b87b
Compare
Except the name of the annotations they looks suspiciously the same :) |
Didn't realize it, probably I should close this instead, sorry |
Adding capability to define pod annotation for PgBouncer.
Ability to define pod annotation on PgBouncer pods.
Sample case: provide annotation for prometheus scraper that configured to look after pod annotation instead of service annotation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.