Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod annotation on PgBouncer #30172

Closed

Conversation

herlambang
Copy link
Contributor

Adding capability to define pod annotation for PgBouncer.

Ability to define pod annotation on PgBouncer pods.
Sample case: provide annotation for prometheus scraper that configured to look after pod annotation instead of service annotation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 17, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just couple minor things to clean up.

chart/values.yaml Outdated Show resolved Hide resolved
chart/values.schema.json Outdated Show resolved Hide resolved
chart/templates/pgbouncer/pgbouncer-deployment.yaml Outdated Show resolved Hide resolved
@herlambang herlambang force-pushed the chart-pgbouncer-pod-annotation branch from de1a047 to 7c2f906 Compare March 18, 2023 01:46
@josh-fell
Copy link
Contributor

@jedcunningham How does this compare/differ from #30168?

@herlambang herlambang requested review from jedcunningham and removed request for dstandish March 18, 2023 04:45
@herlambang herlambang force-pushed the chart-pgbouncer-pod-annotation branch from 7c2f906 to ba43f47 Compare March 20, 2023 05:11
@herlambang herlambang force-pushed the chart-pgbouncer-pod-annotation branch from ba43f47 to 675b87b Compare March 20, 2023 08:59
@potiuk
Copy link
Member

potiuk commented Mar 21, 2023

@jedcunningham How does this compare/differ from #30168?

Except the name of the annotations they looks suspiciously the same :)

@herlambang
Copy link
Contributor Author

Didn't realize it, probably I should close this instead, sorry

@herlambang herlambang closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants