Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pgbouncer doesn't support extraAnnotations for deployment/pod #27246

Closed
2 tasks done
rahulgoyal2987 opened this issue Oct 25, 2022 · 4 comments
Closed
2 tasks done

Pgbouncer doesn't support extraAnnotations for deployment/pod #27246

rahulgoyal2987 opened this issue Oct 25, 2022 · 4 comments
Assignees
@amoghrajesh
Labels
area:helm-chart Airflow Helm Chart good first issue kind:bug This is a clearly a bug

Comments

@rahulgoyal2987
Copy link
Contributor

Official Helm Chart version

1.6.0

Apache Airflow version

2

Kubernetes Version

1.24

Helm Chart configuration

Pgbouncer doesn't support extraAnnotations for deployment/pod

Docker Image customisations

No response

What happened

Pgbouncer doesn't support extraAnnotations for deployment/pod

What you think should happen instead

No response

How to reproduce

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@rahulgoyal2987 rahulgoyal2987 added area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug labels Oct 25, 2022
@rahulgoyal2987
Copy link
Contributor Author

Please find pull request for issue:
https://github.com/apache/airflow/pull/27247/files

@amoghrajesh
Copy link
Contributor

@potiuk @jedcunningham @hussein-awala I see that the issue has gone stale here. Can i pick this up and lead it to completion?

@potiuk
Copy link
Member

potiuk commented Jun 7, 2023

Sure. You should not ping us BTW but rather the person who got assigned, and if no response - continue. @rahulgoyal2987

@amoghrajesh amoghrajesh mentioned this issue Jun 7, 2023
Closed
@jedcunningham
Copy link
Member

This functionality was added in #30168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoghrajesh amoghrajesh

Labels
area:helm-chart Airflow Helm Chart good first issue kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Supporting extraAnnotions at pgbouncer deployment level amoghrajesh/airflow
5 participants
@potiuk @rahulgoyal2987 @amoghrajesh @eladkal @jedcunningham