Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting extraAnnotions at pgbouncer deployment level #31779

Closed

Conversation

amoghrajesh
Copy link
Contributor

Adds support for integrating extraAnnotations in the pgbouncer deployment spec when defined in values.yaml during setup

closes: #27246


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 7, 2023
@amoghrajesh
Copy link
Contributor Author

@potiuk @jedcunningham can I get a review on this PR if you have some free time?

@jedcunningham
Copy link
Member

How is this different than pgbouncer.podAnnotations?

@amoghrajesh
Copy link
Contributor Author

@jedcunningham I was trying to cover up the tech debt due to thseparatePR: #27247
Not sure about the exact intention but looks like an effort to seperate the annotations into podAnnotations and extraAnnotations

@eladkal eladkal added this to the Airflow Helm Chart 1.10.0 milestone Jun 18, 2023
@jedcunningham
Copy link
Member

I don't see any reason to have 2 ways to set annotations on the pod, and podAnnotations is how it's done elsewhere. extraAnnotations is just used on our services.

I've marked that issue as closed by #30168. Thanks @amoghrajesh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pgbouncer doesn't support extraAnnotations for deployment/pod
3 participants