Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade unit tests to use lightweight case load where possible #2296

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

ansjsia
Copy link
Collaborator

@ansjsia ansjsia commented Dec 4, 2023

To speed up solver mode unit tests, tests that don't require loading the mesh have been set to call root.file.read with the parameter lightweight_setup=True.

@ansjsia ansjsia mentioned this pull request Dec 7, 2023
@ansjsia ansjsia marked this pull request as ready for review December 8, 2023 18:53
@raph-luc
Copy link
Member

raph-luc commented Dec 8, 2023

Running solvermode tests here: https://github.com/ansys/pyfluent/actions/runs/7146060041

If any tests fail we can compare with others to see if they were already failing, or if they are new failures: https://github.com/ansys/pyfluent/actions/workflows/weekly-solvermode-test-run.yml

@ansjsia
Copy link
Collaborator Author

ansjsia commented Dec 8, 2023

Running solvermode tests here: https://github.com/ansys/pyfluent/actions/runs/7146060041

If any tests fail we can compare with others to see if they were already failing, or if they are new failures: https://github.com/ansys/pyfluent/actions/workflows/weekly-solvermode-test-run.yml

@raph-luc I'm noticing these solver mode tests are being run with 24.2 rather than 24.1. 2 of the 4 test failures are caused by changes in API object names (test_boundaries.py::test_boundaries_elbow and test_species_model.py::test_change_create_mixture). Should we delay updating them until 24.1 is released?

test_boundaries.py::test_boundaries_periodic is throwing an AssertionError when comparing two dictionaries. I'll have to do some digging to see if this is caused by an API change.

Would you have any idea on how to investigate test_general.py::test_solver_import_mixingelbow throwing an _InactiveRpcError?

@seanpearsonuk
Copy link
Collaborator

Running solvermode tests here: https://github.com/ansys/pyfluent/actions/runs/7146060041
If any tests fail we can compare with others to see if they were already failing, or if they are new failures: https://github.com/ansys/pyfluent/actions/workflows/weekly-solvermode-test-run.yml

@raph-luc I'm noticing these solver mode tests are being run with 24.2 rather than 24.1. 2 of the 4 test failures are caused by changes in API object names (test_boundaries.py::test_boundaries_elbow and test_species_model.py::test_change_create_mixture). Should we delay updating them until 24.1 is released?

test_boundaries.py::test_boundaries_periodic is throwing an AssertionError when comparing two dictionaries. I'll have to do some digging to see if this is caused by an API change.

Would you have any idea on how to investigate test_general.py::test_solver_import_mixingelbow throwing an _InactiveRpcError?

@ansjsia @raph-luc
I believe that we should test against stable APIs here, so yes, we should avoid touching 24.2 at the present time.

@raph-luc
Copy link
Member

@ansjsia when comparing the test results from this branch with those from main, we can see that the test failures from this branch are not due to the changes here: these tests were already failing before with the exact same errors. We shouldn't address those in this PR.

@ansjsia ansjsia merged commit a6f16f3 into main Dec 11, 2023
20 of 21 checks passed
@ansjsia ansjsia deleted the testing/lightweight-case-load branch December 11, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants