Convert rotating disk and Wigley hull to cas.h5 format #214
Conversation
…ghtweight case load
ansjsia
requested review from
dnwillia-work,
mkundu1,
hpohekar,
raph-luc,
h-krishnan,
seanpearsonuk,
ajain-work and
prmukherj
… up after dependencies removed
There was a problem hiding this comment.
I think it would be a good idea to not remove any files in this PR (even if you are fairly sure they aren't being used).
In a subsequent PR, when we do come back to remove the deprecated files, we should request review from the people who added these files, in case they are being used in ways that we did not anticipate.
There was a problem hiding this comment.
Why are we adding .cas.h5 files with wigley_hull/wigley.cas.h5 and rotating_disk/disk.cas.h5? Can't we work with just the .msh.h5 files?
There was a problem hiding this comment.
At least some of the tests that reference these meshes are only concerned with case settings, not with the actual mesh, so adding a cas.h5 version allows us to use lightweight case read on them.
There was a problem hiding this comment.
I think that the settings-only mode can also work with the .msh.h5 files directly:
There was a problem hiding this comment.
You're right, I just confirmed that this also works in PyFluent. This would be relevant for the test relying on wigley_hull.msh.h5. This doesn't work for the 2D meshes I compressed using GZIP (e.g. disk.msh.gz) as they aren't in HDF5 format.
@raph-luc Good point, I've restored all of the original |
Added
cas.h5versions of the rotating disk and Wigley hull mesh files to support using lightweight case loading in solver mode unit tests.EDIT: Also converted all
.mshfiles to.msh.h5(for 3D meshes) or to.msh.gz(for 2D meshes). After merging this PR, the following PRs must also be merged to avoid breaking tests and examples: