Should all .msh files in example-data/pyfluent be compressed?

[ansjsia]

These are the .msh files in example-data/pyfluent:

File	Compressed File	Uploader	PR
box/poly.msh	box/poly.msh.h5	@akulshre-qa	ansys/example-data#61
cavitation/cav.msh	cavitation/cav.msh.gz	@ansaboutin	ansys/example-data#200
examples/Brake-Thermal-PyVista-Matplotlib/brake.msh	examples/Brake-Thermal-PyVista-Matplotlib/brake.msh.h5	@hpohekar	ansys/example-data#79
exhaust_manifold/manifold.msh	exhaust_manifold/manifold.msh.h5	@akulshre-qa	ansys/example-data#61
fan/fan_bc_vent.msh	fan/fan_bc_vent.msh.h5	@akulshre-qa	ansys/example-data#61
lunar_lander_thermal/lander_mesh.msh	lunar_lander_thermal/lander_mesh.msh.h5	@ansjsia	ansys/example-data#207
nozzle/nozzle_3d.msh	nozzle/nozzle_3d.msh.h5	@akulshre-qa	ansys/example-data#61
rotating_disk/disk.msh	rotating_disk/disk.msh.gz	@akulshre-qa	ansys/example-data#55
static_mixer/StaticMixer.msh	static_mixer/StaticMixer.msh.h5	@akulshre-qa	ansys/example-data#61
wigley_hull/wigley.msh	wigley_hull/wigley.msh.h5	@akulshre-qa	ansys/example-data#60

To reduce storage requirements and to avoid slowing down text searches in the example-data repo, should all .msh files there be removed? Compressed versions of these files have already been uploaded.

The following PRs have modified/will modify all (as much as I could find) references to .msh files in PyFluent repositories to .msh.gz or .msh.h5:

• test_initialization.py::test_initialization unit test and load_disk_mesh test fixture in pyfluent: Upgrade unit tests to use lightweight case load where possible #2296
• Cavitation example in pyfluent: refactor: Upgrade examples to 24.1 #2214
• Brake disc and lunar lander examples in pyfluent-examples: Upgrading remaining examples to 24.1 pyfluent-examples#99

Initially suggested by @raph-luc.

[ansjsia]

Potential consideration: Removing .msh files may break examples that rely on them in previous release versions.

[raph-luc]

Thanks @ansjsia, this is a great way to keep track of all the files and to quickly check who added them, as well as when they were added.

Potential consideration: Removing .msh files may break examples that rely on them in previous release versions.

That is a good point. In my understanding, the examples are being developed and are only maintained for the latest public Ansys Fluent releases. It doesn't look to me like backwards compatibility for the examples is something that we have been trying to maintain, but I may be completely wrong. We'll see what the others think.

I also just realized that the PyFluent Examples docs don't even mention what Ansys Fluent version they were developed or tested for.

[ansjsia]

I also just realized that the PyFluent Examples docs don't even mention what Ansys Fluent version they were developed or tested for.

That's a good point, it sounds like we need a way to track version compatibility for the examples. I'll create a separate issue for this.