-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise test markers #2300
Merged
Merged
Revise test markers #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjsia
force-pushed
the
testing/revise-markers
branch
from
December 8, 2023 14:45
f1722fd
to
5348462
Compare
…luent into testing/revise-markers
seanpearsonuk
approved these changes
Dec 11, 2023
ansjsia
requested review from
mkundu1,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar,
h-krishnan and
raph-luc
as code owners
December 11, 2023 14:58
raph-luc
approved these changes
Dec 11, 2023
raph-luc
reviewed
Dec 11, 2023
raph-luc
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following changes in test markers to remove markers with little utility and to improve clarity for intended use:
setup
marker tosettings_only
.settings_only
marker.settings_only
marker to “Read and modify the case settings only without loading the mesh, initializing, or solving the case.”pyproject.toml
:integration
(6 tests)quick
(11 tests)solve
(no tests)mesh
(1 test)optislang
(2 tests)This should not be merged until after PR #2296 is merged because it makes changes to whether some tests initialize or solve.EDIT: #2296 has been merged.