Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise test markers #2300

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Revise test markers #2300

merged 14 commits into from
Dec 11, 2023

Conversation

ansjsia
Copy link
Collaborator

@ansjsia ansjsia commented Dec 7, 2023

Implement the following changes in test markers to remove markers with little utility and to improve clarity for intended use:

  1. Change the name of the setup marker to settings_only.
  2. If the test initializes or solves the case, remove the settings_only marker.
  3. Update the description of the settings_only marker to “Read and modify the case settings only without loading the mesh, initializing, or solving the case.”
  4. Remove the following markers from all tests that use them and from pyproject.toml:
    1. integration (6 tests)
    2. quick (11 tests)
    3. solve (no tests)
    4. mesh (1 test)
    5. optislang (2 tests)

This should not be merged until after PR #2296 is merged because it makes changes to whether some tests initialize or solve.
EDIT: #2296 has been merged.

@ansjsia ansjsia changed the base branch from main to testing/lightweight-case-load December 7, 2023 21:16
@ansjsia ansjsia force-pushed the testing/revise-markers branch from f1722fd to 5348462 Compare December 8, 2023 14:45
Base automatically changed from testing/lightweight-case-load to main December 11, 2023 14:28
@ansjsia ansjsia marked this pull request as ready for review December 11, 2023 14:58
@raph-luc raph-luc self-requested a review December 11, 2023 15:05
@ansjsia ansjsia enabled auto-merge (squash) December 11, 2023 15:06
@ansjsia ansjsia disabled auto-merge December 11, 2023 15:10
@ansjsia ansjsia enabled auto-merge (squash) December 11, 2023 15:53
@ansjsia ansjsia merged commit b0835a5 into main Dec 11, 2023
20 checks passed
@ansjsia ansjsia deleted the testing/revise-markers branch December 11, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants