Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize block proposal #771

Merged
merged 301 commits into from
Dec 21, 2022
Merged

Optimize block proposal #771

merged 301 commits into from
Dec 21, 2022

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 11, 2022 •
edited
Loading

The purpose of this PR is to optimize the usage of block space in proposals, such that we fill the allotted proposal size defined by Tendermint with as many different kinds of txs as possible. We will be dividing it into smaller PRs, to facilitate the reviewing process.

Once this PR merges, we can close #602

Related PRs

Removed PRs

Notes/specs

sug0 added 28 commits November 14, 2022 16:41
@sug0
WIP: Use tx bins in prepare proposal
fc3998a
@sug0
Decrypted tx bin space depends on encrypted txs'
f4be230
@sug0
Some design notes on block space usage
df16fda
@sug0
Begin tx allotments state machine
2446ce3
@sug0
Rebase fixes
2aef45a
@sug0
Revert tx bins PrepareProposal changes
6fc2d46
@sug0
Fix confusing terminology in tx bin unit tests
012af04
@sug0
Add all possible tx bin states
82e8a00
@sug0
Temporarily disable tx bins unit tests
7d831c5
@sug0
WIP: Tx bins state machine impl
28ab01e
@sug0
TODO items
283c374
@sug0
Code review suggestions
17c7c78
@sug0
Add state trait
6c43416
@sug0
Rename block space allocator
33513bb
@sug0
Uncomment next_state() code
0c26aec
@sug0
Make states mod public
ef58cea
@sug0
Impl new state
b22c188
@sug0
Remove unused code
0126231
@sug0
Properly initialize space for protocol txs
a18fd6b
@sug0
Add NextState
2ae93be
@sug0
Refactor State
51cea1f
@sug0
Add convenience traits
8a41254
@sug0
State extension impl
3aad530
@sug0
WIP: Encrypted tx batches
3b41716
@sug0
WIP: Filling remaining space in block
aff268e
@sug0
Choose a wiser mod name for block space allocation
92a386e
@sug0
Temporarily remove tests mod
ea14fe4
@sug0
Fix rustfmt acting up
fe29485
@sug0 sug0 mentioned this pull request Dec 15, 2022
Merged
sug0 and others added 24 commits December 15, 2022 11:15
@sug0
Merge tiago/ethbridge/fix-abcipp-prepare-proposal
3ec3ea6
@sug0
Remove interspersed abcipp logic in PrepareProposal
81a03d1
@sug0
Merge branch 'tiago/ethbridge/fix-abcipp-prepare-proposal' into tiago…
2dbf090 
…/ethbridge/process-proposal-allocator
@sug0
Add block space allocator specs
07ac5ff
@sug0
Merge pull request #897 from anoma/tiago/ethbridge/fix-abcipp-prepare…
698cbc7 
…-proposal

Fix ABCI++ builds in `PrepareProposal`
@sug0
Merge branch 'tiago/ethbridge/optimize-block-proposal' into tiago/eth…
fcf1ee5 
…bridge/process-proposal-allocator
@sug0
Re-order tx building method defs in PrepareProposal
908305b
@sug0
Add missing tx error code in ProcessProposal docstr
93fcdda
@sug0
Merge branch 'tiago/ethbridge/process-proposal-allocator' into tiago/…
5b2002a 
…ethbridge/block-space-allocator-specs
@sug0
Replace B with byte for better readability
b5c791a
@sug0 @batconjurer
Update documentation/specs/src/base-ledger/block-space-allocator.md
f5644bb 
Co-authored-by: Jacob Turner <[email protected]>
@sug0
Fix invalid usage of singular word
591ee74
@sug0 @batconjurer
Update documentation/specs/src/base-ledger/block-space-allocator.md
71d4378 
Co-authored-by: Jacob Turner <[email protected]>
@sug0 @batconjurer
Update documentation/specs/src/base-ledger/block-space-allocator.md
8ab5630 
Co-authored-by: Jacob Turner <[email protected]>
@sug0 @batconjurer
Update documentation/specs/src/base-ledger/block-space-allocator.md
740ea05 
Co-authored-by: Jacob Turner <[email protected]>
@sug0 @batconjurer
Update documentation/specs/src/base-ledger/block-space-allocator.md
cd896b6 
Co-authored-by: Jacob Turner <[email protected]>
@sug0
Add governance specs for max_proposal_bytes updates
1c63c49
@sug0
Explain how the fourth state of the block space allocator works
4d3e6e0
@sug0
Move governance specs to a new sub-section
2fda882
@sug0
Merge pull request #895 from anoma/tiago/ethbridge/process-proposal-a…
a8f5abf 
…llocator

Plug `BlockSpaceAllocator` logic into `ProcessProposal`
@sug0
Merge eth-bridge-integration
bd3aa62
@sug0
Merge branch 'eth-bridge-integration' into tiago/ethbridge/optimize-b…
76c3097 
…lock-proposal
@sug0
Merge tiago/ethbridge/optimize-block-proposal
d533d7f
@sug0
Merge pull request #907 from anoma/tiago/ethbridge/block-space-alloca…
b8d7227 
…tor-specs

Write specs for the `BlockSpaceAllocator`
@sug0 sug0 marked this pull request as ready for review December 21, 2022 15:42
@sug0 sug0 merged commit d44314f into eth-bridge-integration Dec 21, 2022
@sug0 sug0 deleted the tiago/ethbridge/optimize-block-proposal branch December 21, 2022 15:43
@sug0 sug0 mentioned this pull request Dec 21, 2022
Closed
@sug0 sug0 mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ethereum-bridge ledger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sug0