Use BlockSpaceAllocator to construct new blocks during PrepareProposal
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/ethbridge/use-tx-bins
branch
from
cca726c to
3debb4b
Compare
sug0
force-pushed
the
tiago/ethbridge/use-tx-bins
branch
from
3debb4b to
b70d695
Compare
sug0
changed the title
BlockSpaceAllocator to construct new blocks during PrepareProposal
sug0
force-pushed
the
tiago/ethbridge/use-tx-bins
branch
3 times, most recently
from
cda9e25 to
73bb3f2
Compare
sug0
force-pushed
the
tiago/ethbridge/use-tx-bins
branch
from
25771e1 to
f7ee18a
Compare
This reverts commit 6fc2d46.
batconjurer
reviewed
Nov 30, 2022
james-chf
suggested changes
Nov 30, 2022
Comment on lines
+28
to
+30
| build-debug: | ||
| ANOMA_DEV=false $(cargo) build --package namada_apps --manifest-path Cargo.toml | ||
|
|
There was a problem hiding this comment.
This is useful though would separate it out from this PR, it should go towards main (maybe build-apps-release and build-apps-debug would make more sense as target names but it's separate from this PR)
shared/src/hints.rs
Outdated
Comment on lines
1
to
44
| //! Compiler hints, to improve the performance of certain operations. | ||
|
|
||
| /// A function that is seldom called. | ||
| #[inline] | ||
| #[cold] | ||
| pub fn cold() {} | ||
|
|
||
| /// A likely path to be taken in an if-expression. | ||
| /// | ||
| /// # Example | ||
| /// | ||
| /// ```ignore | ||
| /// if likely(frequent_condition()) { | ||
| /// // most common path to take | ||
| /// } else { | ||
| /// // ... | ||
| /// } | ||
| /// ``` | ||
| #[inline] | ||
| pub fn likely(b: bool) -> bool { | ||
| if !b { | ||
| cold() | ||
| } | ||
| b | ||
| } | ||
|
|
||
| /// An unlikely path to be taken in an if-expression. | ||
| /// | ||
| /// # Example | ||
| /// | ||
| /// ```ignore | ||
| /// if unlikely(rare_condition()) { | ||
| /// // ... | ||
| /// } else { | ||
| /// // most common path to take | ||
| /// } | ||
| /// ``` | ||
| #[inline] | ||
| pub fn unlikely(b: bool) -> bool { | ||
| if b { | ||
| cold() | ||
| } | ||
| b | ||
| } |
There was a problem hiding this comment.
Should go towards main, idk much about this. I'd be slightly hesitant to have optimizations like this at this stage (we should be able to do this sort of thing by profiling anyway - https://doc.rust-lang.org/rustc/profile-guided-optimization.html ?).
There was a problem hiding this comment.
I admit I was having way too much fun when I added this module haha
batconjurer
reviewed
Dec 1, 2022
batconjurer
requested changes
Dec 1, 2022
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
…bridge/use-tx-bins
james-chf
approved these changes
Dec 7, 2022
batconjurer
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #791
Plugs the block space allocator implementation into
PrepareProposal.