Implement BlockSpaceAllocator state machine
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2022
Merged
sug0
force-pushed
the
tiago/ethbridge/impl-tx-bins-state-machine
branch
from
be62303 to
17c7c78
Compare
james-chf
reviewed
Nov 22, 2022
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+33
to
+51
| // TODO: what if a tx has a size greater than the threshold for | ||
| // its bin? how do we handle this? if we keep it in the mempool | ||
| // forever, it'll be a DoS vec, as we can make nodes run out of | ||
| // memory! maybe we should allow block decisions for txs that are | ||
| // too big to fit in their respective bin? in these special block | ||
| // decisions, we would only decide proposals with "large" txs?? | ||
| // | ||
| // MAYBE: in the state machine impl, reset to beginning state, and | ||
| // and alloc space for large tx right at the start. the problem with | ||
| // this is that then we may not have enough space for decrypted txs | ||
|
|
||
| // TODO: panic if we don't have enough space reserved for a | ||
| // decrypted tx; in theory, we should always have enough space | ||
| // reserved for decrypted txs, given the invariants of the state | ||
| // machine | ||
|
|
||
| // TODO: refactor our measure of space to also reflect gas costs. | ||
| // the total gas of all chosen txs cannot exceed the configured max | ||
| // gas per block, otherwise a proposal will be rejected! |
There was a problem hiding this comment.
these could have GH issues
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
@james-chf yeah I set them all to draft PRs, since the top priority right now is getting rid of digests. then these PRs will be based on those changes |
james-chf
suggested changes
Nov 28, 2022
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
…bridge/impl-tx-bins-state-machine
batconjurer
reviewed
Nov 29, 2022
| /// | ||
| /// Signal the caller if the tx is larger than its max | ||
| /// allotted bin space. | ||
| fn try_dump(&mut self, tx: &[u8]) -> Result<(), AllocFailure> { |
There was a problem hiding this comment.
Could rename this error as Constipation. 💩
batconjurer
requested changes
Nov 29, 2022
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc/states.rs
Show resolved
Hide resolved
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc.rs
Outdated
Show resolved
Hide resolved
apps/src/lib/node/ledger/shell/prepare_proposal/block_space_alloc/states.rs
Outdated
Show resolved
Hide resolved
james-chf
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #774
Allocate space for the different
TxBininstances depending on the current phase of a type-level state machine. This will be useful to allow, e.g. decrypted txs to use as much space as needed, or to disallow including user encrypted txs in blocks when space is a critical resource needed for protocol level txs.Unit tests will be added in a new PR, to simplify the review process.