Initialize BlockSpaceAllocator with max_proposal_bytes
#887
Conversation
| @@ -165,6 +168,9 @@ pub trait QueriesExt { | |||
| &'db self, | |||
| epoch: Option<Epoch>, | |||
| ) -> Box<dyn Iterator<Item = (EthAddrBook, Address, token::Amount)> + 'db>; | |||
|
|
|||
| /// Retrieve the `max_proposal_bytes` consensus parameter from storage. | |||
| fn get_max_proposal_bytes(&self) -> ProposalBytes; | |||
There was a problem hiding this comment.
for sure QueriesExt can be broken up/refactored/done away with soon! The API of the Storage struct grows further...
There was a problem hiding this comment.
lol yeah, it's just a catch-all basically
There was a problem hiding this comment.
I'm actually deleting it. It will become PosQueries. Any funcitonality that isn't that will have to live elsewhere.
| fn get_max_proposal_bytes(&self) -> ProposalBytes { | ||
| let key = get_max_proposal_bytes_key(); | ||
| let (maybe_value, _gas) = self | ||
| .read(&key) | ||
| .expect("Must be able to read ProposalBytes from storage"); | ||
| let value = | ||
| maybe_value.expect("ProposalBytes must be present in storage"); | ||
| decode(value).expect("Must be able to decode ProposalBytes in storage") | ||
| } |
There was a problem hiding this comment.
I still think ideally we should be returning errors rather than panicking here. The issue is we do not have a nice way to gracefully shut down within Shell ABCI methods upon encountering an unrecoverable error, so we will have to panic somewhere up the stack right now anyway.
There was a problem hiding this comment.
A panic in the shell triggers the abortable spawner which shuts down all the other processes. I think we should panic here.
…bridge/max-proposal-bytes
Based on #771
Initialize
BlockSpaceAllocatorwith themax_proposal_bytesgenesis parameter, instead ofmax_tx_bytes(retrieved fromRequestPrepareProposal).