refactor(e2e-tests): import the instantsearch-e2e-tests repo #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2931f8f:
|
Haroenv
force-pushed
the
feat/import-e2e
branch
2 times, most recently
from
854a553
to
7d52dbf
Compare
Haroenv
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
sarahdayan
reviewed
Nov 23, 2022
Haroenv
force-pushed
the
feat/import-e2e
branch
from
4173de7
to
93f4b48
Compare
…ntsearch-e2e-tests#15) * fix(setSearchBoxValue): reset searchbox before editing In React and Preact the CLEAR selenium instruction does not fire any event, and therefore does not update the component's internal state (see this job for example: https://app.saucelabs.com/tests/4518f96fdfd447e998786d0ff463658a#54) It is equivalent to `input.value = ''`. There are multiple sources reporting a similar behaviour (see SeleniumHQ/selenium#6741) Since this change: #4202 ```jsx <input value={state.query} /> ``` instead of ```jsx <input value={props.query} /> ``` Since binding the input value to a `state.query` (rather than a `props.query`), it appears the click we use to focus on the searchbox re-syncs `input.value` with `state.query`.
…arch-e2e-tests#14) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]>
…ch-e2e-tests#16) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]>
…nstantsearch-e2e-tests#21) * Remove debugging and performance flags on Chrome on SauceLabs. This was making the tests longer to run and therefore getting an higher chance to timeout. * Update helpers to always wait for the URL to be updated. This way we always wait for all changes to be done before running the next command. * Replace the `getTextFromElements` helper by `getTextFromSelector` This helper is way more performant since all operations are made in the browser. It removes a lot of back and forth between the runner and the browser, minimizing the risk of errors. * Round elements coordinates when doing a drag and drop From my tests it improves drag and drop precision on Internet Explorer. There is still some flackyness on drag and drop, but I did not find way to completely solve it.
…instantsearch-e2e-tests#29) BREAKING CHANGE: tested projects now require `@wdio/junit-reporter`.
- wrap tests in "flavor" factory - remove ci setup (doesn't work with old URL anymore) BREAKING CHANGE: this requires the url to be /examples/js/e-commerce instead of /examples/e-commerce. This means that until the package is in the monorepo, its tests wouldn't pass. After the main monorepo PR is merged, this repo will move inside and will no longer be published.
Co-Authored-By: Sarah Dayan <[email protected]>
Haroenv
force-pushed
the
feat/import-e2e
branch
from
93f4b48
to
7c0d464
Compare
sarahdayan
approved these changes
Nov 24, 2022
Co-Authored-By: Sarah Dayan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the state after algolia/instantsearch-e2e-tests#38 and its review
NOTE: this PR must be rebased (not squashed), keeping the original history to have a working
git blameFX-1964