Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

feat: generate junit test reports by default with saucelabs #29

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Jan 11, 2022

BREAKING CHANGE: tested projects now require @wdio/junit-reporter.

@dhayab dhayab requested review from a team, sarahdayan and Haroenv and removed request for a team January 11, 2022 17:12
@dhayab
Copy link
Member Author

dhayab commented Jan 11, 2022

ci/circleci: test is expected to fail since react-instantsearch and vue-instantsearch don't have @wdio/junit-reporter which is mandatory with this PR.

@Haroenv
Copy link

Haroenv commented Jan 11, 2022

you need to add junit to the setup of the ci still

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably bump to a major version if it's a breaking change?

EDIT: reading the contributing guide it would be in the next commit.

@dhayab
Copy link
Member Author

dhayab commented Jan 17, 2022

@Haroenv I added a quick how-to in the README file to help with that.

@francoischalifour thanks for the heads up. I'll follow these steps once it's merged.

@dhayab dhayab merged commit 5f2c0b3 into master Jan 17, 2022
@dhayab dhayab deleted the feat/default-junit-reports branch January 17, 2022 14:13
Haroenv pushed a commit to algolia/instantsearch that referenced this pull request Nov 24, 2022
…instantsearch-e2e-tests#29)

BREAKING CHANGE: tested projects now require `@wdio/junit-reporter`.
Haroenv pushed a commit to algolia/instantsearch that referenced this pull request Nov 24, 2022
…instantsearch-e2e-tests#29)

BREAKING CHANGE: tested projects now require `@wdio/junit-reporter`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants