This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
fix(spec): improve specs reliability to minimize flackyness #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove debugging and performance flags on Chrome on SauceLabs. This was making the tests longer to run and getting an higher chance to timeout. * Update helpers to always wait for the URL to be updated. This way we always wait for all changes to be done before running the next command. * Replace the `getTextFromElements` helper by `getTextFromSelector` This helper is way more performant since all operations are made in the browser. It removes a lot of back and forth between the runner and the browser, minimizing the risk of errors.
francoischalifour
approved these changes
Apr 6, 2020
eunjae-lee
reviewed
Apr 6, 2020
eunjae-lee
approved these changes
Apr 6, 2020
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Nov 24, 2022
…nstantsearch-e2e-tests#21) * Remove debugging and performance flags on Chrome on SauceLabs. This was making the tests longer to run and therefore getting an higher chance to timeout. * Update helpers to always wait for the URL to be updated. This way we always wait for all changes to be done before running the next command. * Replace the `getTextFromElements` helper by `getTextFromSelector` This helper is way more performant since all operations are made in the browser. It removes a lot of back and forth between the runner and the browser, minimizing the risk of errors. * Round elements coordinates when doing a drag and drop From my tests it improves drag and drop precision on Internet Explorer. There is still some flackyness on drag and drop, but I did not find way to completely solve it.
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Nov 24, 2022
…nstantsearch-e2e-tests#21) * Remove debugging and performance flags on Chrome on SauceLabs. This was making the tests longer to run and therefore getting an higher chance to timeout. * Update helpers to always wait for the URL to be updated. This way we always wait for all changes to be done before running the next command. * Replace the `getTextFromElements` helper by `getTextFromSelector` This helper is way more performant since all operations are made in the browser. It removes a lot of back and forth between the runner and the browser, minimizing the risk of errors. * Round elements coordinates when doing a drag and drop From my tests it improves drag and drop precision on Internet Explorer. There is still some flackyness on drag and drop, but I did not find way to completely solve it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple improvements for specs reliability:
Remove debugging and performance flags on Chrome on SauceLabs.
This was making the tests longer to run and therefore getting an higher chance to timeout.
Update helpers to always wait for the URL to be updated.
This way we always wait for all changes to be done before running the next command.
Replace the
getTextFromElementshelper bygetTextFromSelectorThis helper is way more performant since all operations are made in the browser.
It removes a lot of back and forth between the runner and the browser, minimizing the risk of errors.
Round elements coordinates when doing a drag and drop
From my tests it improves drag and drop precision on Internet Explorer. There is still some flackyness on drag and drop, but I did not find way to completely solve it 😞