Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

feat(spec): add custom error messages for timeouts #18

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

yannickcr
Copy link
Contributor

This change adds some custom error messages if a timeout occurs during the test; giving us a clearer explanation of what failed.

Example:

Before:

[chrome 79.0.3945.88 Linux #0-0] 1) InstantSearch - Search on specific category selects "Appliances" category in list
[chrome 79.0.3945.88 Linux #0-0] Error: waitUntil condition timed out after 10000ms

After:

[chrome 79.0.3945.88 Linux #0-1] 1) InstantSearch - Search on specific category selects "Appliances" category in list
[chrome 79.0.3945.88 Linux #0-1] Error: URL was not updated after click on "Appliances" in hierarchical menu

@yannickcr yannickcr requested a review from Haroenv January 10, 2020 13:25
Copy link

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look helpful

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Haroenv Haroenv merged commit 617a22d into master Jan 15, 2020
@Haroenv Haroenv deleted the feat/timeout-messages branch January 15, 2020 09:58
Haroenv pushed a commit to algolia/instantsearch that referenced this pull request Nov 24, 2022
Haroenv pushed a commit to algolia/instantsearch that referenced this pull request Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants