feat(js): pass searchParams to EchoRequester, update CTS
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just realized we could also use the |
shortcuts
force-pushed
the
feat/APIC-247/cts-search-parameters
branch
from
8a08566 to
b0d3e23
Compare
|
CI will not pass because of the Analytics client (others should not be impacted):
Those changes will be applied in a future PR since it's not in the scope of this one |
shortcuts
force-pushed
the
feat/APIC-247/cts-search-parameters
branch
from
633070c to
6cc05ef
Compare
shortcuts
commented
Jan 7, 2022
millotp
reviewed
Jan 10, 2022
millotp
previously approved these changes
Jan 10, 2022
clients/algoliasearch-client-javascript/utils/requester/EchoRequester.ts
Outdated
Show resolved
Hide resolved
millotp
approved these changes
Jan 10, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-247
Changes included:
This PR aims at providing additional content to the
EchoRequester.Motivations
To successfully test
GETrequests and our clients, we will need extra parameters such as:searchParams,userAgent,timeouts,headers, etc.We encounter this first limitation in #69, when we are not able to assert the search parameters.
🧪 Test
CI :D