feat(cts): add tests for analytics
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
reviewed
Jan 7, 2022
| "testName": "get getClickThroughRate with all parameters", | ||
| "parameters": { | ||
| "index": "index", | ||
| "startDate": "1999-19-09", |
There was a problem hiding this comment.
Maybe we should also check the query params to see if this is passed correctly
There was a problem hiding this comment.
Indeed, that's what I was checking
|
Looks like we have issue with URL encoding in the CTS |
I just realized I forgot to run |
|
Waiting for #70 to test search params |
millotp
approved these changes
Jan 7, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-241
Changes included:
analyticsclient and methodsanalyticsclientgenerateCTSscript to provide a new variable:parametersWithDataTypeparametersWithDataType:Provide an array of parameters with their
key,value,is*data types, and the-lastparameter.This allow us to provide custom logic in our CTS template, to wrap a
startDateparameters in theDateconstructor for example.🧪 Test
CI :D