Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): pass searchParams to EchoRequester, update CTS #70

Merged
merged 10 commits into from
Jan 10, 2022
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,50 @@ import type { EndRequest, Request, Response } from '../types';

import { Requester } from './Requester';

type AdditionalContent = {
headers: Record<string, string>;
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
const searchParams = {};

for (const [k, v] of params) {
if (k === 'x-algolia-agent') {
continue;
}

searchParams[k] = v;
}

return searchParams;
}

export class EchoRequester extends Requester {
constructor(private status = 200) {
super();
}

send(_request: EndRequest, originalRequest: Request): Promise<Response> {
send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
const searchParams = searchParamsWithoutUA(urlSearchParams);
const additionalContent: AdditionalContent = {
headers,
connectTimeout,
responseTimeout,
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};

return Promise.resolve({
content: JSON.stringify(originalRequest),
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
isTimedOut: false,
status: this.status,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,50 @@ import type { EndRequest, Request, Response } from '../types';

import { Requester } from './Requester';

type AdditionalContent = {
headers: Record<string, string>;
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
const searchParams = {};

for (const [k, v] of params) {
if (k === 'x-algolia-agent') {
continue;
}

searchParams[k] = v;
}

return searchParams;
}

export class EchoRequester extends Requester {
constructor(private status = 200) {
super();
}

send(_request: EndRequest, originalRequest: Request): Promise<Response> {
send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
const searchParams = searchParamsWithoutUA(urlSearchParams);
const additionalContent: AdditionalContent = {
headers,
connectTimeout,
responseTimeout,
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};

return Promise.resolve({
content: JSON.stringify(originalRequest),
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
isTimedOut: false,
status: this.status,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,50 @@ import type { EndRequest, Request, Response } from '../types';

import { Requester } from './Requester';

type AdditionalContent = {
headers: Record<string, string>;
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
const searchParams = {};

for (const [k, v] of params) {
if (k === 'x-algolia-agent') {
continue;
}

searchParams[k] = v;
}

return searchParams;
}

export class EchoRequester extends Requester {
constructor(private status = 200) {
super();
}

send(_request: EndRequest, originalRequest: Request): Promise<Response> {
send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
const searchParams = searchParamsWithoutUA(urlSearchParams);
const additionalContent: AdditionalContent = {
headers,
connectTimeout,
responseTimeout,
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};

return Promise.resolve({
content: JSON.stringify(originalRequest),
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
isTimedOut: false,
status: this.status,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,50 @@ import type { EndRequest, Request, Response } from '../types';

import { Requester } from './Requester';

type AdditionalContent = {
headers: Record<string, string>;
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
const searchParams = {};

for (const [k, v] of params) {
if (k === 'x-algolia-agent') {
continue;
}

searchParams[k] = v;
}

return searchParams;
}

export class EchoRequester extends Requester {
constructor(private status = 200) {
super();
}

send(_request: EndRequest, originalRequest: Request): Promise<Response> {
send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
const searchParams = searchParamsWithoutUA(urlSearchParams);
const additionalContent: AdditionalContent = {
headers,
connectTimeout,
responseTimeout,
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};

return Promise.resolve({
content: JSON.stringify(originalRequest),
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
isTimedOut: false,
status: this.status,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,50 @@ import type { EndRequest, Request, Response } from '../types';

import { Requester } from './Requester';

type AdditionalContent = {
headers: Record<string, string>;
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
const searchParams = {};

for (const [k, v] of params) {
if (k === 'x-algolia-agent') {
continue;
}

searchParams[k] = v;
}

return searchParams;
}

export class EchoRequester extends Requester {
constructor(private status = 200) {
super();
}

send(_request: EndRequest, originalRequest: Request): Promise<Response> {
send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
const searchParams = searchParamsWithoutUA(urlSearchParams);
const additionalContent: AdditionalContent = {
headers,
connectTimeout,
responseTimeout,
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};

return Promise.resolve({
content: JSON.stringify(originalRequest),
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
isTimedOut: false,
status: this.status,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,50 @@ import type { EndRequest, Request, Response } from '../types';

import { Requester } from './Requester';

type AdditionalContent = {
headers: Record<string, string>;
connectTimeout: number;
responseTimeout: number;
userAgent: string | undefined;
searchParams: Record<string, any>;
};

function searchParamsWithoutUA(params: URLSearchParams): Record<string, any> {
const searchParams = {};

for (const [k, v] of params) {
if (k === 'x-algolia-agent') {
continue;
}

searchParams[k] = v;
}

return searchParams;
}

export class EchoRequester extends Requester {
constructor(private status = 200) {
super();
}

send(_request: EndRequest, originalRequest: Request): Promise<Response> {
send(
{ headers, url, connectTimeout, responseTimeout }: EndRequest,
originalRequest: Request
): Promise<Response> {
const urlSearchParams = new URL(url).searchParams;
const userAgent = urlSearchParams.get('x-algolia-agent') || undefined;
const searchParams = searchParamsWithoutUA(urlSearchParams);
const additionalContent: AdditionalContent = {
headers,
connectTimeout,
responseTimeout,
userAgent: userAgent ? encodeURI(userAgent) : undefined,
searchParams,
};

return Promise.resolve({
content: JSON.stringify(originalRequest),
content: JSON.stringify({ ...originalRequest, ...additionalContent }),
isTimedOut: false,
status: this.status,
});
Expand Down
18 changes: 9 additions & 9 deletions specs/analytics/paths/common/parameters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ Attribute:
schema:
type: string

Search:
in: path
name: search
description: The query term. Must match the exact user input.
required: true
schema:
type: string

# query
OrderBy:
in: query
Expand Down Expand Up @@ -42,15 +50,7 @@ Limit:
type: integer
default: 10

Search:
in: path
name: search
description: The query term. Must match the exact user input.
required: true
schema:
type: string

SearchInPath:
SearchInQuery:
in: path
name: search
description: The query term. Must match the exact user input.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ get:
summary: Returns top filter attributes for a given search.
parameters:
- $ref: '../../../common/parameters.yml#/Index'
- $ref: '../common/parameters.yml#/SearchInPath'
- $ref: '../common/parameters.yml#/SearchInQuery'
- $ref: '../../../common/parameters.yml#/StartDate'
- $ref: '../../../common/parameters.yml#/EndDate'
- $ref: '../common/parameters.yml#/Limit'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ get:
schema:
type: string
- $ref: '../../../common/parameters.yml#/Index'
- $ref: '../common/parameters.yml#/SearchInPath'
- $ref: '../common/parameters.yml#/SearchInQuery'
- $ref: '../../../common/parameters.yml#/StartDate'
- $ref: '../../../common/parameters.yml#/EndDate'
- $ref: '../common/parameters.yml#/Limit'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ get:
summary: Returns top filters for the given no result search.
parameters:
- $ref: '../../../common/parameters.yml#/Index'
- $ref: '../common/parameters.yml#/SearchInPath'
- $ref: '../common/parameters.yml#/SearchInQuery'
- $ref: '../../../common/parameters.yml#/StartDate'
- $ref: '../../../common/parameters.yml#/EndDate'
- $ref: '../common/parameters.yml#/Limit'
Expand Down
2 changes: 1 addition & 1 deletion specs/analytics/paths/search/getTopHitsForSearch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ get:
summary: Returns top hits for the given search.
parameters:
- $ref: '../../../common/parameters.yml#/Index'
- $ref: '../common/parameters.yml#/SearchInPath'
- $ref: '../common/parameters.yml#/SearchInQuery'
- $ref: '../common/parameters.yml#/ClickAnalytics'
- $ref: '../../../common/parameters.yml#/StartDate'
- $ref: '../../../common/parameters.yml#/EndDate'
Expand Down
Loading