Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): analytics paths and params #73

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix(specs): analytics paths and params #73

merged 1 commit into from
Jan 10, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-248

Changes included:

  • Paths were not correct, we were missing query params and paths values when using the search parameter.
  • startDate and endDate are actually not dates, but yyyy-mm-dd format strings.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team January 10, 2022 09:12
@shortcuts shortcuts self-assigned this Jan 10, 2022
@shortcuts shortcuts requested review from damcou and removed request for a team January 10, 2022 09:12
This was referenced Jan 10, 2022
Merged
Merged
damcou
damcou approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@shortcuts shortcuts merged commit db35de7 into feat/APIC-247/cts-search-parameters Jan 10, 2022
@shortcuts shortcuts deleted the fix/analytics-specs branch January 10, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @damcou