Fixed ClientSession initialization warning #1518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to remake #1507 to fix a Merge Conflict for just 1 commit. Sorry about that. |
This was referenced Dec 28, 2016
Current coverage is 98.92% (diff: 100%)@@ master #1518 diff @@
==========================================
Files 30 30
Lines 7000 7007 +7
Methods 0 0
Messages 0 0
Branches 1169 1170 +1
==========================================
+ Hits 6925 6932 +7
Misses 37 37
Partials 38 38
|
asvetlov
requested changes
Dec 31, 2016
aiohttp/client.py
Outdated
| @@ -54,7 +54,7 @@ def __init__(self, *, connector=None, loop=None, cookies=None, | |||
| if loop.get_debug(): | |||
| self._source_traceback = traceback.extract_stack(sys._getframe(1)) | |||
|
|
|||
| if not loop.is_running(): | |||
| if not loop.is_running() and loop is not None: | |||
There was a problem hiding this comment.
Check for None shoud be first: it's fastpath.
There was a problem hiding this comment.
I fixed an issue in the None check I wrote is not none instead of is None.
There was a problem hiding this comment.
uh, so I tested it and sadly the final for loop line must be if loop is not None: because otherwise if I check if the loop is running with the current None check it would raise an AttributeError.
This fixes an issue with ClientSession throwing a warnings when feeding an event loop into it when calling it from a normal function. This should help silence annoying warnings for libraries that "lazy" initializes ClientSession and properly closes the session and handles it. Now those libraries would have no need for a useless bug reports.
|
Ok, So Sadly I might need to reopen this PR so this is only 1 commit. And so it would be also up to date with this repo. |
|
Remade as #1572. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with ClientSession throwing a warning when feeding
an event loop into it when calling it from a normal function. This
should help silence annoying warnings for libraries that "lazy"
initializes ClientSession and properly closes the session and handles
it. Now those libraries would have no need for a useless bug reports.
What do these changes do?
Fixes the warning when calling a ClientSession instance with an event loop that is passed to the class.
Are there changes in behavior for the user?
No, just adds more control over the ClientSession instance.
Related issue number
#1468 (comment)
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.