-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ClientSession initialization warning #1572
Conversation
This fixes an issue with ClientSession throwing a warning when feeding an event loop into it when calling it from a normal function. This should help silence annoying warnings for libraries that "lazy" initializes ClientSession and properly closes the session and handles it. Now those libraries would have no need for useless bug reports.
@asvetlov There seems to be an issue with some tests on AppVeyor. However I know these should succeed. |
Codecov Report@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
+ Coverage 98.54% 98.57% +0.03%
==========================================
Files 32 30 -2
Lines 7265 7107 -158
Branches 1208 1181 -27
==========================================
- Hits 7159 7006 -153
+ Misses 61 60 -1
+ Partials 45 41 -4
Continue to review full report at Codecov.
|
i do not understand you |
Look at https://ci.appveyor.com/project/asvetlov/aiohttp/build/1.1.0a0.dev3847/job/9pxom9fkwakhiodo It shows 2 recive tests failing. With |
last build is green |
Yeah, travis works just AppVeyor sometimes fails on me for no reason at all. |
@fafhrd91 turns out that it seems the test failure on AppVeyor seems to now be fixed. |
This fixes an issue with ClientSession throwing a warning when feeding
an event loop into it when calling it from a normal function. This
should help silence annoying warnings for libraries that "lazy"
initializes ClientSession and properly closes the session and handles
it. Now those libraries would have no need for useless bug reports.
What do these changes do?
Fixes the warning when calling a ClientSession instance with an event loop that is passed to the class.
Are there changes in behavior for the user?
No, just adds more control over the ClientSession instance.
Related issue number
#1468 (comment)
Checklist
CONTRIBUTORS.txt
CHANGES.rst
#issue_number
format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.