Fixed misses in helpers

[AraHaan]

This commit fixes all 4 of the misses in helpers.py.

What do these changes do?

Fix the Misses in helpers.py

Are there changes in behavior for the user?

No changes in behavior at all.

Related issue number

None

Checklist

• Unit tests for the changes exist
• I think the code is well written

[codecov-io]

Current coverage is 98.94% (diff: 100%)

Merging #1521 into master will increase coverage by 0.05%

@@             master      #1521   diff @@
==========================================
  Files            30         30          
  Lines          6990       6984     -6   
  Methods           0          0          
  Messages          0          0          
  Branches       1163       1162     -1   
==========================================
- Hits           6912       6910     -2   
+ Misses           39         35     -4   
  Partials         39         39          

Powered by Codecov. Last update 8469b6d...ce9f016

[AraHaan]

@fafhrd91 What you think of this PR? Also I noticed there was a missing 0 in the version so I fixed that as well in this PR, btw you could also look in #1518 as well to. It also contains my entry in CONTRIBUTORS.txt

[fafhrd91]

i don't think it worth to create new module just for import checks.
also it seems nothing uses check_loop

[AraHaan]

So, Check loop can be safely removed. I see.

[AraHaan]

Ok, then check_loop has now been removed completely since it is not getting used anyway so yeah.

[fafhrd91]

I leave this PR to @asvetlov
He is active maintainer

[AraHaan]

Ok, found a way to help get what we need. Using getattr for if asyncio.ensure_future does not exist it returns asyncio.async and use 1 line.

[AraHaan]

Looks like I just had to monkey patch 1 of the tests as sometimes it would fail at web.run_app hmm but is more often then not rare. So, when it happens should make it instead of the pass that I am doing right now to make it xfail

[asvetlov]

I've dropped check_loop and fixed version number. 39b8568
ensure_future is covered by running on different python versions.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.