Fixed ClientSession initialization warning #1507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.86% (diff: 100%)@@ master #1507 diff @@
==========================================
Files 30 30
Lines 6990 6990
Methods 0 0
Messages 0 0
Branches 1163 1163
==========================================
- Hits 6912 6911 -1
Misses 39 39
- Partials 39 40 +1
|
AraHaan
changed the title
|
Ok, this PR should be complete to fix the warning stuff when feeding in the event loop when they create a ClientSession outside of a coroutine @asvetlov. Happy Merging. |
This should hopefully reduce the Parials down to none for client.py.
This fixes an issue with ClientSession throwing a warnings when feeding an event loop into it when calling it from a normal function. This should help silence annoying warnings for libraries that "lazy" initializes ClientSession and properly closes the session and handles it. Now those libraries would have no need for a useless bug reports.
|
Wow... Well then guess this PR must be remade... |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with ClientSession throwing a warnings when feeding
an event loop into it when calling it from a normal function. This
should help silence annoying warnings for libraries that "lazy"
initializes ClientSession and properly closes the session and handles
it. Now those libraries would have no need for a useless bug reports.
What do these changes do?
Fixes the warning when calling a ClientSession instance with an event loop that is passed to the class.
Are there changes in behavior for the user?
No, just adds more control over the ClientSession instance.
Related issue number
#1468 (comment)
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.