Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new test for aiohttp.ws_connect #1508

Merged
merged 1 commit into from
Dec 28, 2016
Merged

Added a new test for aiohttp.ws_connect #1508

merged 1 commit into from
Dec 28, 2016

Conversation

AraHaan
Copy link
Contributor

@AraHaan AraHaan commented Dec 25, 2016

This should hopefully reduce the Partials down to none for client.py.

What do these changes do?

Fix the Coverage for client.py on the number of Parials.

Are there changes in behavior for the user?

No, everything remains the same, just added 1 more test for ws_connect.

Related issue number

No issues for this. Just fixing some coverage issues.

Checklist

  • I think the code is well written
  • Add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.

This should hopefully reduce the Parials down to none for client.py.
@codecov-io
Copy link

codecov-io commented Dec 25, 2016

Current coverage is 98.88% (diff: 100%)

Merging #1508 into master will increase coverage by 0.01%

@@             master      #1508   diff @@
==========================================
  Files            30         30          
  Lines          6986       6986          
  Methods           0          0          
  Messages          0          0          
  Branches       1163       1163          
==========================================
+ Hits           6907       6908     +1   
  Misses           39         39          
+ Partials         40         39     -1   

Powered by Codecov. Last update 6da8ae9...9ce3fcc

@AraHaan
Copy link
Contributor Author

AraHaan commented Dec 27, 2016

@asvetlov Think these tests are fine? Btw if this is merged it will help boost the coverage on client.py to 100%.

@asvetlov
Copy link
Member

Ok

@asvetlov asvetlov merged commit 93316c8 into aio-libs:master Dec 28, 2016
@AraHaan AraHaan deleted the patch_ws_test branch December 28, 2016 19:06
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants