Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next priority list of updates & fixes before new website going live #90

Closed
17 of 18 tasks
lulen11 opened this issue Jan 20, 2020 · 14 comments
Closed
17 of 18 tasks

Next priority list of updates & fixes before new website going live #90

lulen11 opened this issue Jan 20, 2020 · 14 comments
Assignees
Labels

Comments

@lulen11
Copy link
Contributor

lulen11 commented Jan 20, 2020

Hey team,

Creating this as as an epic with a checklist of all the smaller issues listed here (please edit and add to this as you please).

I think best thing would be for us to first add the item to the checklist here. Then go and create an issue or directly open a PR that would tackle the checklist item (and would provide a place for us to have specific conversation directly related to said issue). Then please link the issue/PR you created to the checklist item in here, as well as tagging the main person responsible for each item.

First priority:

Second priority:

Nice to have:


Side note: I think I should have created this as a “release” not an “epic” but too late now. I'm aware... My bad.

@kbardi
Copy link
Contributor

kbardi commented Jan 20, 2020

Hey @lulen11 I'm working on some of those issues.
Update node version done in #101, still need to fix a gimbal/lighthouse issue.
Link blueprint version also I did there, but not sure to understand what is the problem there...

@bronz3beard bronz3beard pinned this issue Jan 21, 2020
@bronz3beard
Copy link
Contributor

Hey @lulen11
I think the check boxes for;
Footer: Remove Become a Partner link / make it activate Intercom if easy.
Footer: "Shop Apparel" isn't linked to the shop.

Are all sorted, you can see in this PR shop links to shop and Partner links to intercom FAQ

or maybe I'm missing something? Hopefully you can tick them off your list :-)

@lulen11
Copy link
Contributor Author

lulen11 commented Jan 21, 2020

Thanks @kbardi - when they're done, please link and check them off the list :)

And thanks @bronz3beard - the shop apparel link looks good but left you a comment / change request about the partner link :)

@bronz3beard
Copy link
Contributor

Thanks @kbardi - when they're done, please link and check them off the list :)

And thanks @bronz3beard - the shop apparel link looks good but left you a comment / change request about the partner link :)

FAQ and Become a Partner has been updated now. here I have ticked it off the list remove FAQ in footer.

@kbardi
Copy link
Contributor

kbardi commented Jan 21, 2020

Thanks @kbardi - when they're done, please link and check them off the list :)

And thanks @bronz3beard - the shop apparel link looks good but left you a comment / change request about the partner link :)

Probably at the end of my day I'll merge my PR with many changes...I'll let you know @lulen11

@rin
Copy link

rin commented Jan 22, 2020

About the beta message, adding a notification thing to Blueprint is not on my list right now (it's not a huge thing, I just think it's not that much of a priority) so for the website, hardcoding something subtle sounds like a better idea! (Also because I think as a "notification" it would draw too much attention? Which sounds spammy to me.) (You're the 1 millionth visitor of this website! You win a free iPhone!) 😉

@lulen11
Copy link
Contributor Author

lulen11 commented Jan 22, 2020

About the beta message, adding a notification thing to Blueprint is not on my list right now (it's not a huge thing, I just think it's not that much of a priority) so for the website, hardcoding something subtle sounds like a better idea! (Also because I think as a "notification" it would draw too much attention? Which sounds spammy to me.) (You're the 1 millionth visitor of this website! You win a free iPhone!) 😉

hi @rin - i've taken care of a temporary beta message on #106 now

@lulen11
Copy link
Contributor Author

lulen11 commented Jan 22, 2020

hi @kbardi

I've worked through quite a bit of this today. Running into issues that I would love your help with on #104

Apart from that, I've opened PRs for the rest (some with questions for you)

And there's one item left to do which is:

Check/fix donate page. May be broken because v5 domain is blocked by Raisly @kbardi

@mischacolley
Copy link
Contributor

I'm still not seeing the correct font when I go to http://v5.aimementoring.com/? See https://www.loom.com/share/08bded6afa5341c1b40d238c500193ca

Is that being fixed somewhere? Maybe the correct version of Blueprint still isn't being loaded/variables wrong? Also @lulen11 I feel like those headings will need a fallback font stack?

@lulen11
Copy link
Contributor Author

lulen11 commented Jan 22, 2020

I'm still not seeing the correct font when I go to http://v5.aimementoring.com/?

Are you cached @mischacolley ? I've checked it on incognito and I've disabled my local fonts too and still is all working for me.

also @lulen11 I feel like those headings will need a fallback font stack?

But yes 🤦‍♀ 100%. Will fix that up today on a new PR. I just went into Blueprint and checked... They do have a fallback - I've set them up to go back to the old font styles (see below). @charliemckenzie in the future, maybe we could source a similar standard-ish font we can use as fallbacks for luna emu and gt pressura mono?

Instances of stylised font: "Luna Emu", "Poppins Black", "Arial Black", "sans serif"
Instances of feature font: "GT Pressura Mono Bold", "Univers Bold", "Helvetica Neue", Helvetica, Arial, sans-serif

@charliemckenzie
Copy link
Contributor

Good thinking @lulen11 ! Will have a think about this :)

@mischacolley
Copy link
Contributor

@charliemckenzie this issue will likely be closed soon so I'd break the font stuff out into seperate issues :)

@kbardi
Copy link
Contributor

kbardi commented Jan 29, 2020

We fixed some issues related to font stuff yesterday, so is it still failing the font in any page? @mischacolley @lulen11

@kbardi
Copy link
Contributor

kbardi commented Jan 29, 2020

Vertically centre nav items (it’s most pronounced when sticky)
@lulen11 is this error still happening? I can see it vertically centered
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants