-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next priority list of updates & fixes before new website going live #90
Comments
Hey @lulen11 Are all sorted, you can see in this PR shop links to shop and Partner links to intercom FAQ or maybe I'm missing something? Hopefully you can tick them off your list :-) |
Thanks @kbardi - when they're done, please link and check them off the list :) And thanks @bronz3beard - the shop apparel link looks good but left you a comment / change request about the partner link :) |
|
Probably at the end of my day I'll merge my PR with many changes...I'll let you know @lulen11 |
About the beta message, adding a notification thing to Blueprint is not on my list right now (it's not a huge thing, I just think it's not that much of a priority) so for the website, hardcoding something subtle sounds like a better idea! (Also because I think as a "notification" it would draw too much attention? Which sounds spammy to me.) (You're the 1 millionth visitor of this website! You win a free iPhone!) 😉 |
hi @rin - i've taken care of a temporary beta message on #106 now |
hi @kbardi I've worked through quite a bit of this today. Running into issues that I would love your help with on #104 Apart from that, I've opened PRs for the rest (some with questions for you) And there's one item left to do which is:
|
I'm still not seeing the correct font when I go to http://v5.aimementoring.com/? See https://www.loom.com/share/08bded6afa5341c1b40d238c500193ca Is that being fixed somewhere? Maybe the correct version of Blueprint still isn't being loaded/variables wrong? Also @lulen11 I feel like those headings will need a fallback font stack? |
Are you cached @mischacolley ? I've checked it on incognito and I've disabled my local fonts too and still is all working for me.
But yes 🤦♀ 100%. Instances of stylised font: |
Good thinking @lulen11 ! Will have a think about this :) |
@charliemckenzie this issue will likely be closed soon so I'd break the font stuff out into seperate issues :) |
We fixed some issues related to font stuff yesterday, so is it still failing the font in any page? @mischacolley @lulen11 |
|
Hey team,
Creating this as as an epic with a checklist of all the smaller issues listed here (please edit and add to this as you please).
I think best thing would be for us to first add the item to the checklist here. Then go and create an issue or directly open a PR that would tackle the checklist item (and would provide a place for us to have specific conversation directly related to said issue). Then please link the issue/PR you created to the checklist item in here, as well as tagging the main person responsible for each item.
First priority:
Second priority:
Nice to have:
Side note: I think I should have created this as a “release” not an “epic” but too late now. I'm aware... My bad.
The text was updated successfully, but these errors were encountered: