Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes gimbal node version #101

Merged
merged 16 commits into from
Jan 22, 2020
Merged

Fixes gimbal node version #101

merged 16 commits into from
Jan 22, 2020

Conversation

kbardi
Copy link
Contributor

@kbardi kbardi commented Jan 20, 2020

resolves #91

@kbardi kbardi self-assigned this Jan 20, 2020
@vercel
Copy link

vercel bot commented Jan 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/aimementoring/website/exevjpd2n
✅ Preview: https://website-git-bugfix-22-node-version.aimementoring.now.sh

@aime-bot aime-bot temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 20, 2020 17:27 Inactive
@kbardi kbardi changed the base branch from master to staging January 20, 2020 17:27
@vercel vercel bot requested a deployment to Preview January 20, 2020 18:20 Abandoned
@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 20, 2020 18:20 Inactive
@vercel vercel bot requested a deployment to Preview January 20, 2020 18:50 Abandoned
@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 20, 2020 18:50 Inactive
@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 20, 2020 18:56 Inactive
@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 20, 2020 19:08 Inactive
@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 20, 2020 19:54 Inactive
@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 21, 2020 00:30 Inactive
Copy link
Contributor

@bronz3beard bronz3beard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
I just want to check, do we need any of these plugins for gimbal also?: Available Plugins

@kbardi
Copy link
Contributor Author

kbardi commented Jan 21, 2020

Looks good,
I just want to check, do we need any of these plugins for gimbal also?: Available Plugins

Hey @bronz3beard, yes, I'm having issues loading some gimbal plugins and I do not understand why is that happening...if you can check that would be great

@bronz3beard bronz3beard temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 22, 2020 00:37 Inactive
@bronz3beard bronz3beard temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 22, 2020 00:40 Inactive
@bronz3beard bronz3beard temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 22, 2020 01:05 Inactive
@bronz3beard bronz3beard had a problem deploying to website-v5-bugfix-22-no-zkw1ng January 22, 2020 02:00 Failure
@bronz3beard bronz3beard had a problem deploying to website-v5-bugfix-22-no-zkw1ng January 22, 2020 02:10 Failure
@bronz3beard bronz3beard temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 22, 2020 03:22 Inactive
@@ -49,7 +47,7 @@
"cross-fetch": "^3.0.4",
"dotenv": "^8.2.0",
"express": "^4.17.1",
"filestack-react": "^3.1.0",
"filestack-react": "2.0.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded modules trying to fix a Gimbal issue and I had to downgrade filestack-react for now to fix build issue. filestack-js known issue

@bronz3beard bronz3beard temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 22, 2020 03:32 Inactive
@bronz3beard
Copy link
Contributor

bronz3beard commented Jan 22, 2020

@kbardi
I have fixed the CI workflow, the script and node issue for AWS.

Gimbal is working locally but the rest is really strange! What I have learnt is this.

It has its own version of sqlite3 this is a native module written in some type of C maybe C++ this means it will install the version we need in the used environment architecture, so if we change node version we have to remove and add again these two plugins; so we have the correct sqlite3 version.

@modus/gimbal-plugin-last-value
@modus/gimbal-plugin-sqlite <- sqlite3 is installed with this plugin
NOTE: Gimbal plugins are now not in dev dependencies as i followed exactly install instructions from modus, I thought this could help not sure anymore.

In the action WF, the file that it says is missing node_sqlite3.node can be found locally in my node_modules at /Users/bronzebeard/Desktop/repos/AIME/website/node_modules/@modus/gimbal-plugin-sqlite/node_modules/sqlite3/lib/binding/node-v72-darwin-x64/node_sqlite3.node.

In the action wf it is looking for the file in /github/workspace/node_modules/sqlite3/lib/binding/node-v64-linux-x64/node_sqlite3.node

I cant figure out why this is happening?
These plugins are used to store tests and make comparisons to the last time the test was run.

I could ask Modus but they have not actioned my last issue, so I don't know how quickly we will get a respond to this one also.

I think the issue could be around changing our node version recently, I think sqlite3 is compatible with 12.x, but maybe not the version Gimbal is using as a dependency for a plugin (nested dependencies) which I am 95% sure is v4.1.0?

Maybe this info can help you find an answer, I hope.
If not we may have to wait for the next version of Gimbal, just run it locally or I will find another performance monitoring module for us to use.
Running locally gives some really great results which is great! @camposcristianeze

@kbardi kbardi temporarily deployed to website-v5-bugfix-22-no-zkw1ng January 22, 2020 20:49 Inactive
@kbardi kbardi merged commit c41456d into staging Jan 22, 2020
@kbardi kbardi deleted the bugfix/22-node-version branch January 22, 2020 21:49
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants