Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove all refs to contact us #77 #100

Merged
merged 6 commits into from
Jan 21, 2020
Merged

Feature/remove all refs to contact us #77 #100

merged 6 commits into from
Jan 21, 2020

Conversation

bronz3beard
Copy link
Contributor

resolves #77

All references to contact page have been removed minus some styles. not sure if they are needed or not.

Mobile menu is NOT functioning correctly, for reach out to us I am not sure of the status of mobile device layout/functionality so I will leave that for now and open another issue at a later date.

here is a file for proposed intercom "redirects" throughout the site. Intercom enquirers.

@vercel
Copy link

vercel bot commented Jan 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@vercel vercel bot requested a deployment to Preview January 20, 2020 11:34 Abandoned
@bronz3beard bronz3beard temporarily deployed to website-v5-feature-remo-lftzc6 January 20, 2020 11:34 Inactive
@vercel vercel bot requested a deployment to Preview January 20, 2020 11:43 Abandoned
@bronz3beard bronz3beard requested review from kbardi and lulen11 January 20, 2020 11:46
@bronz3beard bronz3beard self-assigned this Jan 20, 2020
@bronz3beard bronz3beard added this to the Migrate main pages by AI milestone Jan 20, 2020
@bronz3beard bronz3beard requested a review from lubem234 January 20, 2020 11:47
kbardi
kbardi reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@kbardi kbardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I think we can simplify the way we render Footer links and properties

components/layoutComponents/footer/index.js Outdated Show resolved Hide resolved
@kbardi
Copy link
Contributor

kbardi commented Jan 20, 2020

Build is not working because it needs the apiKey for bugsnag

@bronz3beard
Copy link
Contributor Author

It looks good, but I think we can simplify the way we render Footer links and properties

@kbardi totally agree! I wanted to simplify a few things but it was quicker to work with what was there rather than refactor.

@bronz3beard
Copy link
Contributor Author

bronz3beard commented Jan 21, 2020 •
edited
Loading

Build is not working because it needs the apiKey for bugsnag

has Heroku been replaced by now? I am not sure what the procedure is with adding keys to now, can i just add whatever i need to make it work e.g. everything?

I dont know where the issue is for this, where do i need to add the apiKey? It is in all env's locations and is present in /utils
? bugsnag({ apiKey: process.env.REACT_APP_BUGSNAG_KEY,

Do i need to edit the CI action?

@bronz3beard bronz3beard temporarily deployed to website-v5-feature-remo-vuufuh January 21, 2020 03:55 Inactive
lulen11
lulen11 requested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@lulen11 lulen11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rory!

This looks good! Only thing - I saw you referenced that "Become a Partner" in the footer links to the intercom FAQ. Could you please either change to link to the intercom online chat OR delete the "Become a Partner" link from the footer?

I don't think we should link to the intercom FAQ from the regular links on the website - only in specific FAQ examples... It's not a great UX for the user to be directed to a long word doc type piece of content while browsing through the site. We'll eventually design a better UX for this but for now - just intercom chat or delete the link please :)

@lulen11 lulen11 mentioned this pull request Jan 21, 2020
Closed
18 tasks
@bronz3beard
Copy link
Contributor Author

Hey Rory!

This looks good! Only thing - I saw you referenced that "Become a Partner" in the footer links to the intercom FAQ. Could you please either change to link to the intercom online chat OR delete the "Become a Partner" link from the footer?

I don't think we should link to the intercom FAQ from the regular links on the website - only in specific FAQ examples... It's not a great UX for the user to be directed to a long word doc type piece of content while browsing through the site. We'll eventually design a better UX for this but for now - just intercom chat or delete the link please :)

It was actually added by someone else (maybe me ages ago in v4 haha) but the links the go to an external page were not working?
Totally agree about UX, and long docs to read!
I will make that change to the intercom chat for now and update the doc, then whenever we have a better plan for BAP we can add that 😃

@lulen11
Copy link
Contributor

lulen11 commented Jan 21, 2020

Yay thank you! While you're in there editing that footer link, could you also please remove the FAQs link? Thank you!

@bronz3beard
Copy link
Contributor Author

Yay thank you! While you're in there editing that footer link, could you also please remove the FAQs link? Thank you!

delete for now or hide?

@lulen11
Copy link
Contributor

lulen11 commented Jan 21, 2020

Delete is fine, we can add it back in when we're ready

@bronz3beard bronz3beard temporarily deployed to website-v5-feature-remo-vuufuh January 21, 2020 06:48 Inactive
@kbardi kbardi self-requested a review January 21, 2020 21:49
kbardi
kbardi approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@kbardi kbardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lulen11
lulen11 approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@lulen11 lulen11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY thaaanks Rory. Ready to merge it!

@bronz3beard bronz3beard merged commit cc1dcb0 into staging Jan 21, 2020
@kbardi kbardi deleted the feature/remove-all-refs-to-contactUs-#77 branch June 26, 2020 02:26
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
@bronz3beard
Feature/remove all refs to contact us #77 (#100)
f8a7675 
* WIP removing contact references for intercom

* removed all contact refs but some styles mobile menu not updated

* added changes based on review

* added changes based on second review
camposcristian pushed a commit that referenced this pull request Jul 17, 2020
@bronz3beard
Feature/remove all refs to contact us #77 (#100)
5af7f2f 
* WIP removing contact references for intercom

* removed all contact refs but some styles mobile menu not updated

* added changes based on review

* added changes based on second review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbardi kbardi kbardi approved these changes

@lulen11 lulen11 lulen11 approved these changes

@lubem234 lubem234 Awaiting requested review from lubem234

Assignees
No one assigned
Labels
enh:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bronz3beard @kbardi @lulen11