Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEO meta to website pages #88

Closed
bronz3beard opened this issue Jan 17, 2020 · 4 comments
Closed

Add SEO meta to website pages #88

bronz3beard opened this issue Jan 17, 2020 · 4 comments

Comments

@bronz3beard
Copy link
Contributor

Okay finding context for SEO is a bit sparse, so I want to bring it altogether here.

We need to add SEO to the new website.
Currently this is managed by craft in v-4, we don't want that for v-5.

We have this file here: SEO Tags JSON
We have this comment here [Comment](#4 (comment)
Also there is this short video directive from Cris here

So I think the best idea would be to use the NextJs <Head><meta... /></Head> component import Head from 'next/head'; the hoc component would look some thing like this:

Screen Shot 2020-01-17 at 3 51 21 pm

Then something like react-helmet to override those parent tags per page, ReactHelmet can get the info from the static json which we will build out as per Cris's video, from the files extracted by Kevin from Craft.

@lulen11 @camposcristianeze @mischacolley @kbardi
Let me know if this is the best plan of attack for this and please add anything missing or any further ideas/guidance for moving forward with adding SEO tags to site.

p.s. there is discussion and a vision for having Contentful possibly handle some tags but its only a vision/idea right now.

@bronz3beard bronz3beard added this to the Migrate main pages by AI milestone Jan 17, 2020
@lulen11
Copy link
Contributor

lulen11 commented Jan 19, 2020

This looks good to me @bronz3beard - I'm assuming this would just cover meta tags. Have we set up Google Tag Manager? Maybe that's a separate issue.

@bronz3beard
Copy link
Contributor Author

This looks good to me @bronz3beard - I'm assuming this would just cover meta tags. Have we set up Google Tag Manager? Maybe that's a separate issue.

Yep, just meta tags, GTM is in staging but i don't know if it is setup on google? maybe @camposcristianeze knows about this?

@mischacolley
Copy link
Contributor

GTM should be all good to go from my memory of what @camposcristianeze did with it a few months back .... essentially would be using the same container as the current live site. @lulen11 if you can create a post go live checklist and put this on it, to confirm Analytics is tracking, that would be great 🙏🏻

@camposcristian
Copy link
Contributor

GTM should be all good to go from my memory of what @camposcristianeze did with it a few months back .... essentially would be using the same container as the current live site. @lulen11 if you can create a post go live checklist and put this on it, to confirm Analytics is tracking, that would be great 🙏🏻

Nope. All we have from GTM was for that rushed Global release on v4 and after that these notes from Misch after a call we had (@mischacolley are you able to track this recording?)

We didn't test this on v5 as we changed de architecture back then. Should be a matter of just adding the containers in the same way as v4 and testing. The url for that is https://tagmanager.google.com/ and everyone on the team should have access to it. But in any case there's no relation between SEO tags and this so that should be a completely different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants