Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images aren't loading properly #93

Closed
lulen11 opened this issue Jan 20, 2020 · 4 comments
Closed

Images aren't loading properly #93

lulen11 opened this issue Jan 20, 2020 · 4 comments
Assignees
@lulen11

Comments

@lulen11
Copy link
Contributor

lulen11 commented Jan 20, 2020

hey @bronz3beard, maybe you know why this is?

Screen Shot 2020-01-20 at 2 28 08 pm
@lulen11 lulen11 mentioned this issue Jan 20, 2020
Closed
18 tasks
@bronz3beard
Copy link
Contributor

@lulen11 @kbardi

This was just a .env variable not added to Heroku, all is good now on staging.
staging/about

@lulen11 lulen11 mentioned this issue Jan 21, 2020
Merged
@lulen11 lulen11 assigned lulen11 and unassigned bronz3beard Jan 21, 2020
@lulen11
Copy link
Contributor Author

lulen11 commented Jan 21, 2020

ok thanks @bronz3beard

@kbardi I have updated the .env variables in this PR too - #99 and made a comment here - #99 (comment)

@bronz3beard
Copy link
Contributor

This is complete right? Or is there more to it?

@kbardi
Copy link
Contributor

kbardi commented Jan 29, 2020

I think it is done, and we should create maybe a new issue to improve images, generate webp files and load images with srcSet according to the device and the image size

@lulen11 lulen11 closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lulen11 lulen11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kbardi @bronz3beard @lulen11