[pull] main from elastic:main #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
### Description Recently it was discovered that our initial path to analytics brings some inconsistency into Enterprise Search routes, so it was decided to replace the `analytics/api` path with `api/analytics`. This PR is dedicated to changing Analytics DNS path from `analytics/api` to `api/analytics`
This breaks out inline code in `x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts` to functions in separate files and adds jest unit tests for each function. The mocks used for jest unit tests are used as expected data in the API integration tests. This allows to make sure that the static mocks are still up to date should we have to update API integration tests based on upstream tests.
Towards #147379 ## Summary When investigating how to [onboard detection alerts onto framework alert summaries](#147379), there were some discrepancies in the format of the alert documents returned. This PR fixes the formatting so it matches and there will be no difference in `context.alerts` when we migrate detection alerts to the framework. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…ent status (#147552) ## Summary Part of #143455 Previously agents would be unenrolled after a given time by the fleet server. Instead, they'll be considered `Inactive`. Agents in an `Inactive` state are hidden from the UI by default, but their API keys remain active. This allows these agents to check in again at any time without requesting new API keys.`inactivity_timeout` defaults to 10 minutes or can be configured on a per policy basis. Agents that are manually unenrolled will go into the new `Unenrolled` status.  These changes mean that we now need to get agent policies before knowing the agents status, we have used a runtime field to calculate the status at search time, this allows us to easily filter and aggregate on the status. ### Performance For 120 agents (20 of each main status): - filter call with filters: 90ms - agent status summary call: 83ms For 12k agents (2k of each main status): - filter call with filters: 455ms - agent status summary call: 500ms For 120k agents (20k of each main status): - filter call with filters: 2.2s - agent status summary call: 2.1s ### Manual Testing the create agent script can be used to test this at scale e.g create 10k agents of each of the given statuses: ```bash cd x-pack/plugins/fleet node scripts/create_agents --count 10000 --kibana http://localhost:5601/myprefix--status offline,online,inactive,error,updating,unenrolled --inactivityTimeout 360 --delete ``` ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
|
Documentation preview: |
## Summary Added 'Technical preview' badge in title <img width="998" alt="Снимок экрана 2022-12-21 в 14 33 26" src="https://user-images.githubusercontent.com/16915480/208905936-b530844c-bec6-4573-a08c-5b1210cdd50e.png"> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
## Summary Limited combobox height for the purpose of Filter Editor usability. https://user-images.githubusercontent.com/22456368/208945217-fb124e33-8235-42ae-858a-912147bb5175.mov
## Summary Part of #147803 Replaces the text with the proposed text from the docs team <img width="997" alt="image" src="https://user-images.githubusercontent.com/17003240/208633280-d6a78732-0034-454f-9f62-cf6ea14ce4f3.png">
## Summary part of: #146870 This PR will make it easier to add mobile filters to other pages - Rename `useFiltersForMobileCharts` to `useFiltersForEmbeddableCharts` - Add mobile filters in the mobile template - Passing `showMobileFilters=true` will render the component to the page https://user-images.githubusercontent.com/3369346/209121227-aa923836-335d-4ffb-a604-d82c2b0d34ae.mov
… Artifacts API RBAC (#143273) ## Summary - Add new test cases checking RBAC privileges for all artifacts integration tests ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <[email protected]>
## Summary Fixes: #147922 previously we set `-1` as `pageIndex` if we have empty data, but in this case it should be `0`.
…rolling Endpoints (#147718) ## Summary Removes an old, deprecated feature that calls the Agents API filtered by Endpoints. This type of call hasn't been supported for some time (over a year or so). It was realized that it was failing more when we made the RBAC changes for this release and we were getting `403` errors from the API. NOTE: This feature hasn't worked since the creation of Fleet Server, so it is safe to remove. The required query functionality of getting a set of Agents filtered by only those running Endpoint was removed when we switched over to Fleet Server about 1.5 years ago. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: kibanamachine <[email protected]>
## Summary Looking at why Discover was loading data view field lists were loading more than needed, I found more reasons than actual field list loads occurring but I think they're all deserving of improvement. - Discover was loading the default data view to see if there was an existing data view. We can rely on the `hasData` api instead. - We were loading a data view and then refreshing the field list. If the data view was being loaded fresh, its meant the field list was loaded twice. Field list refresh has been integrated into the dataViews api. - We were loading a data view, checking it if was adhoc, and tossing it if it wasn't. Now we keep the reference. Previously on page load, discover would make 3 calls to `fields_for_wildcard`, now it makes two. It loads all the field with one request and it makes an additional request where it applies the current filter to find relevant fields. Closes #147744
## Summary <details><summary>Display link on rule details page -> add exception flyout</summary> <img width="1108" alt="image" src="https://user-images.githubusercontent.com/616158/209036807-973a83b9-2903-4d45-a15d-7fd6751f30a1.png"> </details> <details><summary>Adds manage rules functionality to list view overflow menu</summary> <img width="802" alt="Screen Shot 2022-12-21 at 4 59 11 PM" src="https://user-images.githubusercontent.com/915763/209010900-4b609f9c-6fb1-46ca-a1f9-6aa3e67f5366.png"> </details> <details><summary>Renames page to Shared exception lists and updates page description with hyperlink to manage rules page</summary> <img width="635" alt="Screen Shot 2022-12-21 at 4 58 58 PM" src="https://user-images.githubusercontent.com/915763/209010964-2c7ba8bd-7b1c-4bf9-a0a6-12a456386aed.png"> </details> <details><summary>Updates sidebar title + navigation title</summary> <img width="590" alt="Screen Shot 2022-12-21 at 4 58 36 PM" src="https://user-images.githubusercontent.com/915763/209011050-45df0005-37eb-42b7-840f-eb916472d987.png"> </details> ~~@jethr0null FYI displaying all shared exception lists on the rule details -> add exception flyout is not possible for 8.6. The ability to add any exception to any list was not part of the original design of the component and would require more time to update the component and the data model to allow for this sort of flexibility.~~ Looks like the above is possible if we pass in `null` for the rules property of the `AddExceptionFlyout` but we might want to finalize a design to better help users trying to add the exception to a shared list while **inside** of the rule details page. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Pedro Jaramillo <[email protected]> Co-authored-by: Khristinin Nikita <[email protected]>
…event filters (#148000) ## Summary - Removes id field on nested entries for event filters using the write transform method. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
## Summary The defaultIndex setting title and description were poor. I've updated them to correctly reference data views and be more specific about where they're used. Closes #143609
## Summary Fixes: #140172 This PR - updates filter of Recent Cases in Security Dashboard from ButtonSelection to Dropdown. - it also adds option to select recent cases by `assigned to me` option i.e. it allows to filter Recent cases which are assigned to user. **Before:** <img width="1639" alt="image" src="https://user-images.githubusercontent.com/117571355/208679744-34b6af71-038a-4cb3-b893-0dc0a43fac31.png"> **After:** https://user-images.githubusercontent.com/117571355/208679791-9483c97d-6ef9-4688-ab26-78c5a3764c6b.mov ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) **Flakey Test Runner:**   ## Release Note: See "My recently assigned cases" to the recent cases widget of Security Solution dashboard - Add the ability to filter recent cases by "assigned to me" which will show top 3 recent cases assigned to user. Co-authored-by: Kibana Machine <[email protected]>
Closes #146701. ### Changes - `getApmAlertsClient` was moved from `service-groups` to `helper` folder. - `getServicesAlerts` method was created in order to get the active alerts from services matching filters (timeframe, env, service-group, etc). - `getServicesItems` is now also getting the service alerts and merging them in the results so a knew property was added to service results: `alertsCount`. - Alerts badge was added to service inventory page. **After the changes** - From service inventory https://user-images.githubusercontent.com/1313018/207597602-21412be9-be7b-4b8a-8eb8-37416b6c10bc.mov - From a service group https://user-images.githubusercontent.com/1313018/207597893-d4d19a21-b936-4bbd-beaa-9f3ac6c051b8.mov - After Weekly UI presentation and sync with @boriskirov and @chrisdistasio, we decided to add a loading indicator to serviceGroupCards to give users a hint that something is loading in the background. This is how it looks like: https://user-images.githubusercontent.com/1313018/208681846-4a47f593-1010-4471-86f2-18b196c40684.mov
## Summary Fix #147853 (See issue for more context) Given we don't want to spend much effort in user impersonation right now, the compromise would be to make sure that our system is resilient to creating 'stubbed' requests. The best way to do that is to offer an official, proper way to instantiate `CoreKibanaRequest` without having a proper `HAPI.Request` instance. This PR is introducing the `FakeRawRequest` type, and changing the signature of `CoreKibanaRequest.create` to accept this new type. https://github.com/elastic/kibana/blob/d2eb3e1801ee7bee7503a5ce7d0a6c4789804095/packages/core/http/core-http-server/src/router/raw_request.ts#L14-L36 The PR also adapts the existing, non-test usages of `CoreKibanaRequest.from(someUglyStub as unknown as Request)` to use the new `FakeRawRequest` type instead.
## Summary Partially addresses #147756 - starts using `ReactMenuItem` directly, when available. - removes dependence on `uiToReactComponent` in `build_eui_context_menu_panels.tsx`. Co-authored-by: kibanamachine <[email protected]>
…nctional tests. (#148013)
…art margin (#147137) ## Summary This PR addresses #137257 and better handles the layout when the screen width decreases. Changes include: - The css is now updating based on the body content width (which window's width - side bar navigation's width). - The link cards are shown in the bottom instead of on the right side when the content width is smaller - Refresh button will only show the refresh icon when the size is small - Fix the doc count chart margin too big causing the chart - Fix wide time range display with sparse data For reviewers: - **kibana-design**: 2 `.scss` files were deleted Before After <img width="1223" alt="Screen Shot 2022-12-06 at 14 31 27" src="https://user-images.githubusercontent.com/43350163/206016842-f884ee1f-eb60-4c83-9ad3-2fd0f7c90005.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <[email protected]>
## Summary `[email protected]` ⏩ `[email protected]` --- ## [`72.0.0`](https://github.com/elastic/eui/tree/v72.0.0) - Added the `customQuickSelectRender` render prop to `EuiSuperDatePicker`, which allows customizing the Quick Select popover ([#6382](elastic/eui#6382)) - `EuiFilePicker` styles have been updated to look more like an interactive element. ([#6479](elastic/eui#6479)) - Added a third argument to `EuiSelectable`'s `onChange` callback. The single `option` object that triggered the `onChange` event is now also passed to consumers with its most recent `checked` state ([#6487](elastic/eui#6487)) **Bug fixes** - `EuiTabs` now passes `size` and `expand` to all children using a React context provider. ([#6478](elastic/eui#6478)) - Fixed security warnings caused by `[email protected]` sub-dependency ([#6482](elastic/eui#6482)) **Breaking changes** - Removed `size` and `expand` props from `EuiTab` ([#6478](elastic/eui#6478)) ## [`71.1.0`](https://github.com/elastic/eui/tree/v71.1.0) **Deprecations** - Renamed `EuiPageSideBarProps` to `EuiPageSideBarProps_Deprecated`, to reduce usage/confusion with `EuiPageSidebar` ([#6468](elastic/eui#6468)) Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )