[ML] Explain Log Rate Spikes: Additional unit tests. #147451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
146162a-fix-item-set-filter
branch
5 times, most recently
from
79604ef to
a86db3e
Compare
walterra
changed the title
14 tasks
walterra
force-pushed
the
146162a-fix-item-set-filter
branch
5 times, most recently
from
c9df488 to
97a2a1c
Compare
walterra
force-pushed
the
146162a-fix-item-set-filter
branch
from
97a2a1c to
4e3055a
Compare
walterra
added
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Module Count
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Dec 22, 2022
This breaks out inline code in `x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts` to functions in separate files and adds jest unit tests for each function. The mocks used for jest unit tests are used as expected data in the API integration tests. This allows to make sure that the static mocks are still up to date should we have to update API integration tests based on upstream tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #147170.
This breaks out inline code in
x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.tsto functions in separate files and adds jest unit tests for each function. The mocks used for jest unit tests are used as expected data in the API integration tests. This allows to make sure that the static mocks are still up to date should we have to update API integration tests based on upstream tests.Checklist