Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] change wording on advanced settings UI on default index to default index pattern. #143609

Closed
TomonoriSoejima opened this issue Oct 19, 2022 · 4 comments · Fixed by #147730
Labels
docs Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@TomonoriSoejima
Copy link
Contributor

It took me a while to figure out what default index means until I landed on https://www.elastic.co/guide/en/kibana/7.17/index-patterns-api-default-set.html and understood that it is talking about index pattern.

Please consider to make this change to soften the confusion.

[preview] This functionality is in technical preview and may be changed or removed in a future release. Elastic will apply best effort to fix any issues, but features in technical preview are not subject to the support SLA of official GA features.Set a default index pattern ID. Kibana UI will use default index pattern unless user picks a different one. The API doesn’t validate if given index_pattern_id is a valid id.

image

@TomonoriSoejima TomonoriSoejima added the bug Fixes for quality problems that affect the customer experience label Oct 19, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 19, 2022
@TomonoriSoejima TomonoriSoejima added docs and removed bug Fixes for quality problems that affect the customer experience labels Oct 19, 2022
@afharo afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 24, 2022
@afharo afharo added Team:AppServicesSv and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@afharo
Copy link
Member

afharo commented Oct 24, 2022

Apologies for the noise... it's actually owned by AppServices:

defaultIndex: {
name: i18n.translate('data.advancedSettings.defaultIndexTitle', {
defaultMessage: 'Default index',
}),
value: null,
type: 'string',
description: i18n.translate('data.advancedSettings.defaultIndexText', {
defaultMessage: 'The index to access if no index is set',
}),
schema: schema.nullable(schema.string()),
},

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Oct 24, 2022
@petrklapka petrklapka added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Dec 19, 2022
mattkime added a commit that referenced this issue Dec 22, 2022
## Summary

The defaultIndex setting title and description were poor. I've updated
them to correctly reference data views and be more specific about where
they're used.

Closes #143609
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 22, 2022
…ic#147730)

## Summary

The defaultIndex setting title and description were poor. I've updated
them to correctly reference data views and be more specific about where
they're used.

Closes elastic#143609

(cherry picked from commit b697704)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 22, 2022
…ic#147730)

## Summary

The defaultIndex setting title and description were poor. I've updated
them to correctly reference data views and be more specific about where
they're used.

Closes elastic#143609

(cherry picked from commit b697704)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 22, 2022
…ic#147730)

## Summary

The defaultIndex setting title and description were poor. I've updated
them to correctly reference data views and be more specific about where
they're used.

Closes elastic#143609

(cherry picked from commit b697704)
kibanamachine referenced this issue Dec 22, 2022
…147730) (#148023)

# Backport

This will backport the following commits from `main` to `8.5`:
- [defaultIndex setting description fix - its really a data view!
(#147730)](#147730)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T17:14:56Z","message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data
Views","Feature:Kibana
Management","release_note:skip","Team:DataDiscovery","backport:all-open","v8.7.0"],"number":147730,"url":"https://github.com/elastic/kibana/pull/147730","mergeCommit":{"message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147730","number":147730,"mergeCommit":{"message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <[email protected]>
kibanamachine referenced this issue Dec 22, 2022
…147730) (#148024)

# Backport

This will backport the following commits from `main` to `8.6`:
- [defaultIndex setting description fix - its really a data view!
(#147730)](#147730)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T17:14:56Z","message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data
Views","Feature:Kibana
Management","release_note:skip","Team:DataDiscovery","backport:all-open","v8.7.0"],"number":147730,"url":"https://github.com/elastic/kibana/pull/147730","mergeCommit":{"message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147730","number":147730,"mergeCommit":{"message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <[email protected]>
kibanamachine referenced this issue Dec 22, 2022
…#147730) (#148022)

# Backport

This will backport the following commits from `main` to `7.17`:
- [defaultIndex setting description fix - its really a data view!
(#147730)](#147730)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T17:14:56Z","message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data
Views","Feature:Kibana
Management","release_note:skip","Team:DataDiscovery","backport:all-open","v8.7.0"],"number":147730,"url":"https://github.com/elastic/kibana/pull/147730","mergeCommit":{"message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147730","number":147730,"mergeCommit":{"message":"defaultIndex
setting description fix - its really a data view! (#147730)\n\n##
Summary\r\n\r\nThe defaultIndex setting title and description were poor.
I've updated\r\nthem to correctly reference data views and be more
specific about where\r\nthey're used.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/143609","sha":"b69770463981cc2270b3bb95ac8dd7e02741bf32"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants