Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Reduce number of request for fields when switching a data view in Discover #147744

Closed
kertal opened this issue Dec 19, 2022 · 1 comment · Fixed by #147825
Closed

[Discover] Reduce number of request for fields when switching a data view in Discover #147744

kertal opened this issue Dec 19, 2022 · 1 comment · Fixed by #147825
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Dec 19, 2022

When there's a data view switch in Discover, this currently leads to 3 requests for the data views fields. Ideally there should be just one.
Bildschirmfoto 2022-12-19 um 09 21 38
While this ain't a problem for data views with a small number of fields, it should be optimized for data views with a larger number of fields
@kertal kertal added Feature:Discover Discover Application performance Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Dec 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added loe:needs-research This issue requires some research before it can be worked on or estimated impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 19, 2022
@mattkime mattkime mentioned this issue Dec 20, 2022
Merged
mattkime added a commit that referenced this issue Dec 22, 2022
@mattkime
[discover] Less field list loading (#147825)
4715e71 
## Summary

Looking at why Discover was loading data view field lists were loading
more than needed, I found more reasons than actual field list loads
occurring but I think they're all deserving of improvement.

- Discover was loading the default data view to see if there was an
existing data view. We can rely on the `hasData` api instead.
- We were loading a data view and then refreshing the field list. If the
data view was being loaded fresh, its meant the field list was loaded
twice. Field list refresh has been integrated into the dataViews api.
- We were loading a data view, checking it if was adhoc, and tossing it
if it wasn't. Now we keep the reference.

Previously on page load, discover would make 3 calls to
`fields_for_wildcard`, now it makes two. It loads all the field with one
request and it makes an additional request where it applies the current
filter to find relevant fields.

Closes #147744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[discover] Less field list loading mattkime/kibana
2 participants
@kertal @elasticmachine